Title: [182514] trunk/Websites/perf.webkit.org
- Revision
- 182514
- Author
- [email protected]
- Date
- 2015-04-07 20:39:27 -0700 (Tue, 07 Apr 2015)
Log Message
Perf dashboard should have a way of marking outliers
https://bugs.webkit.org/show_bug.cgi?id=143466
Reviewed by Chris Dumez.
Address kling's in-person comment to notify users when the new run status is saved in the database.
* public/v2/app.js:
(App.PaneController._selectedItemIsMarkedOutlierDidChange)
* public/v2/chart-pane.css: Fixed a typo.
Modified Paths
Diff
Modified: trunk/Websites/perf.webkit.org/ChangeLog (182513 => 182514)
--- trunk/Websites/perf.webkit.org/ChangeLog 2015-04-08 01:51:10 UTC (rev 182513)
+++ trunk/Websites/perf.webkit.org/ChangeLog 2015-04-08 03:39:27 UTC (rev 182514)
@@ -5,6 +5,19 @@
Reviewed by Chris Dumez.
+ Address kling's in-person comment to notify users when the new run status is saved in the database.
+
+ * public/v2/app.js:
+ (App.PaneController._selectedItemIsMarkedOutlierDidChange)
+ * public/v2/chart-pane.css: Fixed a typo.
+
+2015-04-07 Ryosuke Niwa <[email protected]>
+
+ Perf dashboard should have a way of marking outliers
+ https://bugs.webkit.org/show_bug.cgi?id=143466
+
+ Reviewed by Chris Dumez.
+
Added UI to mark a data point as an outlier as well as a button to toggle the visibility of outliers.
Added a new privileged API /privileged-api/update-run-status to store this boolean flag.
Modified: trunk/Websites/perf.webkit.org/public/v2/app.js (182513 => 182514)
--- trunk/Websites/perf.webkit.org/public/v2/app.js 2015-04-08 01:51:10 UTC (rev 182513)
+++ trunk/Websites/perf.webkit.org/public/v2/app.js 2015-04-08 03:39:27 UTC (rev 182514)
@@ -1072,9 +1072,10 @@
return;
var pane = this.get('model');
selectedMeasurement.setMarkedOutlier(!!selectedItemIsMarkedOutlier).then(function () {
+ alert(selectedItemIsMarkedOutlier ? 'Marked the point as an outlier' : 'The point is no longer marked as an outlier');
pane.refetchRuns();
}, function (error) {
- alert(error);
+ alert('Failed to update the status:' + error);
});
}.observes('selectedItemIsMarkedOutlier'),
});
Modified: trunk/Websites/perf.webkit.org/public/v2/chart-pane.css (182513 => 182514)
--- trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-04-08 01:51:10 UTC (rev 182513)
+++ trunk/Websites/perf.webkit.org/public/v2/chart-pane.css 2015-04-08 03:39:27 UTC (rev 182514)
@@ -96,7 +96,7 @@
}
.stat-pane,
-.annotation-pane {
+.analysis-pane {
right: 2.6rem;
padding: 0;
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
