Title: [182525] trunk/Source/WebCore
Revision
182525
Author
[email protected]
Date
2015-04-08 00:44:50 -0700 (Wed, 08 Apr 2015)

Log Message

Remove CSS functions min() and max() which had been dropped from specification
https://bugs.webkit.org/show_bug.cgi?id=143440

Patch by Joonghun Park <[email protected]> on 2015-04-08
Reviewed by Darin Adler.

No new tests, No Behavior changes.

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::create):
* css/CSSParser.cpp:
(WebCore::CSSParser::isCalculation):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (182524 => 182525)


--- trunk/Source/WebCore/ChangeLog	2015-04-08 07:29:23 UTC (rev 182524)
+++ trunk/Source/WebCore/ChangeLog	2015-04-08 07:44:50 UTC (rev 182525)
@@ -1,3 +1,17 @@
+2015-04-08  Joonghun Park  <[email protected]>
+
+        Remove CSS functions min() and max() which had been dropped from specification
+        https://bugs.webkit.org/show_bug.cgi?id=143440
+
+        Reviewed by Darin Adler.
+
+        No new tests, No Behavior changes.
+
+        * css/CSSCalculationValue.cpp:
+        (WebCore::CSSCalcValue::create):
+        * css/CSSParser.cpp:
+        (WebCore::CSSParser::isCalculation):
+
 2015-04-07  Philippe Normand  <[email protected]>
 
         [GStreamer] extra-headers and keep-alive properties for HTTP source element

Modified: trunk/Source/WebCore/css/CSSCalculationValue.cpp (182524 => 182525)


--- trunk/Source/WebCore/css/CSSCalculationValue.cpp	2015-04-08 07:29:23 UTC (rev 182524)
+++ trunk/Source/WebCore/css/CSSCalculationValue.cpp	2015-04-08 07:44:50 UTC (rev 182525)
@@ -758,7 +758,6 @@
 
     if (equalIgnoringCase(name, "calc(") || equalIgnoringCase(name, "-webkit-calc("))
         _expression_ = parser.parseCalc(&parserValueList);
-    // FIXME: calc (http://webkit.org/b/16662) Add parsing for min and max here
 
     return _expression_ ? adoptRef(new CSSCalcValue(_expression_.releaseNonNull(), range != CalculationRangeAll)) : nullptr;
 }

Modified: trunk/Source/WebCore/css/CSSParser.cpp (182524 => 182525)


--- trunk/Source/WebCore/css/CSSParser.cpp	2015-04-08 07:29:23 UTC (rev 182524)
+++ trunk/Source/WebCore/css/CSSParser.cpp	2015-04-08 07:44:50 UTC (rev 182525)
@@ -7223,9 +7223,7 @@
 {
     return (value.unit == CSSParserValue::Function)
         && (equalIgnoringCase(value.function->name, "calc(")
-            || equalIgnoringCase(value.function->name, "-webkit-calc(")
-            || equalIgnoringCase(value.function->name, "-webkit-min(")
-            || equalIgnoringCase(value.function->name, "-webkit-max("));
+            || equalIgnoringCase(value.function->name, "-webkit-calc("));
 }
 
 inline int CSSParser::colorIntFromValue(ValueWithCalculation& valueWithCalculation)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to