Title: [182578] trunk/Source/WebInspectorUI
- Revision
- 182578
- Author
- [email protected]
- Date
- 2015-04-08 18:37:52 -0700 (Wed, 08 Apr 2015)
Log Message
Fix uncaught exception seen in Inspector.
Reviewed by Timothy Hatcher.
* UserInterface/Views/TreeOutline.js:
(WebInspector.TreeOutline.prototype.removeChild):
Add a null check. Everywhere else null checks this member variable
which may not exist yet, this case was missing the check.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (182577 => 182578)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-09 01:37:50 UTC (rev 182577)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-09 01:37:52 UTC (rev 182578)
@@ -1,3 +1,14 @@
+2015-04-08 Joseph Pecoraro <[email protected]>
+
+ Fix uncaught exception seen in Inspector.
+
+ Reviewed by Timothy Hatcher.
+
+ * UserInterface/Views/TreeOutline.js:
+ (WebInspector.TreeOutline.prototype.removeChild):
+ Add a null check. Everywhere else null checks this member variable
+ which may not exist yet, this case was missing the check.
+
2015-04-08 Tobias Reiss <[email protected]>
Web Inspector: Regression: Showing of color swatches no longer works in Details Sidebar
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js (182577 => 182578)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-04-09 01:37:50 UTC (rev 182577)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TreeOutline.js 2015-04-09 01:37:52 UTC (rev 182578)
@@ -195,7 +195,8 @@
this.removeChildAtIndex(childIndex, suppressOnDeselect, suppressSelectSibling);
if (!this.children.length) {
- this._listItemNode.classList.remove("parent");
+ if (this._listItemNode)
+ this._listItemNode.classList.remove("parent");
this.hasChildren = false;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
