Title: [182749] trunk
- Revision
- 182749
- Author
- [email protected]
- Date
- 2015-04-13 12:52:11 -0700 (Mon, 13 Apr 2015)
Log Message
Cannot click "Next" button on Google two-factor auth setup page
<https://bugs.webkit.org/show_bug.cgi?id=143624>
<rdar://problem/19175714>
.:
Reviewed by Darin Adler.
* ManualTests/button-that-focuses-itself-on-click.html: Added.
Source/WebKit2:
This issue occurs when this site focuses the submit button. When it
receives focus, we try to assist it. While we consider ourselves to be
assisting it, we ignore further gesture inputs for that node, including
the tap gesture.
To fix this, only assist input types that we know are assistable,
including text fields, select and date elements, etc.
Reviewed by Darin Adler.
* UIProcess/ios/WKContentViewInteraction.mm:
(isAssistableInputType):
If the type is a known-assistable type, return true.
(-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
Call isAssistableInputType() to determine whether we should do any kind
of assistance for this node.
Modified Paths
Added Paths
Diff
Modified: trunk/ChangeLog (182748 => 182749)
--- trunk/ChangeLog 2015-04-13 19:17:48 UTC (rev 182748)
+++ trunk/ChangeLog 2015-04-13 19:52:11 UTC (rev 182749)
@@ -1,3 +1,14 @@
+2015-04-10 Jon Honeycutt <[email protected]>
+
+ Cannot click "Next" button on Google two-factor auth setup page
+
+ <https://bugs.webkit.org/show_bug.cgi?id=143624>
+ <rdar://problem/19175714>
+
+ Reviewed by Darin Adler.
+
+ * ManualTests/button-that-focuses-itself-on-click.html: Added.
+
2015-04-13 Michael Catanzaro <[email protected]>
[cmake] REGRESSION(182663): It broke feature dependency handling
Added: trunk/ManualTests/button-that-focuses-itself-on-click.html (0 => 182749)
--- trunk/ManualTests/button-that-focuses-itself-on-click.html (rev 0)
+++ trunk/ManualTests/button-that-focuses-itself-on-click.html 2015-04-13 19:52:11 UTC (rev 182749)
@@ -0,0 +1,33 @@
+<head>
+ <meta name="viewport" content="width=device-width">
+ <script>
+ var haveClicked = false;
+ function runTest(e) {
+ if (haveClicked) {
+ e.value = "Test passed";
+ e.disabled = true;
+ return;
+ }
+ e.value = "Click me again";
+ e.focus();
+ haveClicked = true;
+ }
+ </script>
+</head>
+
+<body>
+ <center>
+ <input type=submit _onclick_="runTest(this); return false;" value="Click me" style="font-size: 36px">
+ </center>
+ <br><br>
+ <div style="font-size: 20px; font-family: helvetica;">
+ Test for WebKit bug #<a href=""
+ <br><br>
+ Tap button above twice to run test. “Test passed” will
+ appear above if the test passes. If you cannot click the button a
+ second time, the test failed.
+ <br><br>
+ To rerun this test, open it in a new tab. Do not reload.
+ </div>
+</body>
+
Modified: trunk/Source/WebKit2/ChangeLog (182748 => 182749)
--- trunk/Source/WebKit2/ChangeLog 2015-04-13 19:17:48 UTC (rev 182748)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-13 19:52:11 UTC (rev 182749)
@@ -1,3 +1,27 @@
+2015-04-10 Jon Honeycutt <[email protected]>
+
+ Cannot click "Next" button on Google two-factor auth setup page
+
+ <https://bugs.webkit.org/show_bug.cgi?id=143624>
+ <rdar://problem/19175714>
+
+ This issue occurs when this site focuses the submit button. When it
+ receives focus, we try to assist it. While we consider ourselves to be
+ assisting it, we ignore further gesture inputs for that node, including
+ the tap gesture.
+
+ To fix this, only assist input types that we know are assistable,
+ including text fields, select and date elements, etc.
+
+ Reviewed by Darin Adler.
+
+ * UIProcess/ios/WKContentViewInteraction.mm:
+ (isAssistableInputType):
+ If the type is a known-assistable type, return true.
+ (-[WKContentView _startAssistingNode:userIsInteracting:blurPreviousNode:userObject:]):
+ Call isAssistableInputType() to determine whether we should do any kind
+ of assistance for this node.
+
2015-04-13 Beth Dakin <[email protected]>
Add force property to MouseEvents
Modified: trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm (182748 => 182749)
--- trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-04-13 19:17:48 UTC (rev 182748)
+++ trunk/Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm 2015-04-13 19:52:11 UTC (rev 182749)
@@ -2765,6 +2765,36 @@
return _formAccessoryView.get();
}
+static bool isAssistableInputType(InputType type)
+{
+ switch (type) {
+ case InputType::ContentEditable:
+ case InputType::Text:
+ case InputType::Password:
+ case InputType::TextArea:
+ case InputType::Search:
+ case InputType::Email:
+ case InputType::URL:
+ case InputType::Phone:
+ case InputType::Number:
+ case InputType::NumberPad:
+ case InputType::Date:
+ case InputType::DateTime:
+ case InputType::DateTimeLocal:
+ case InputType::Month:
+ case InputType::Week:
+ case InputType::Time:
+ case InputType::Select:
+ return true;
+
+ case InputType::None:
+ return false;
+ }
+
+ ASSERT_NOT_REACHED();
+ return false;
+}
+
- (void)_startAssistingNode:(const AssistedNodeInformation&)information userIsInteracting:(BOOL)userIsInteracting blurPreviousNode:(BOOL)blurPreviousNode userObject:(NSObject <NSSecureCoding> *)userObject
{
if (!userIsInteracting && !_textSelectionAssistant)
@@ -2773,6 +2803,9 @@
if (blurPreviousNode)
[self _stopAssistingNode];
+ if (!isAssistableInputType(information.elementType))
+ return;
+
// FIXME: We should remove this check when we manage to send StartAssistingNode from the WebProcess
// only when it is truly time to show the keyboard.
if (_assistedNodeInformation.elementType == information.elementType && _assistedNodeInformation.elementRect == information.elementRect)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
