Title: [182763] trunk/Source/_javascript_Core
- Revision
- 182763
- Author
- [email protected]
- Date
- 2015-04-13 15:57:18 -0700 (Mon, 13 Apr 2015)
Log Message
Unreviewed, fix Windows build. Windows doesn't take kindly to private classes that use FAST_ALLOCATED.
* runtime/InferredValue.h:
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (182762 => 182763)
--- trunk/Source/_javascript_Core/ChangeLog 2015-04-13 22:33:44 UTC (rev 182762)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-04-13 22:57:18 UTC (rev 182763)
@@ -1,5 +1,11 @@
2015-04-13 Filip Pizlo <[email protected]>
+ Unreviewed, fix Windows build. Windows doesn't take kindly to private classes that use FAST_ALLOCATED.
+
+ * runtime/InferredValue.h:
+
+2015-04-13 Filip Pizlo <[email protected]>
+
Unreviewed, fix build. I introduced a new cell type at the same time as kling changed how new cell types are written.
* runtime/InferredValue.h:
Modified: trunk/Source/_javascript_Core/runtime/InferredValue.h (182762 => 182763)
--- trunk/Source/_javascript_Core/runtime/InferredValue.h 2015-04-13 22:33:44 UTC (rev 182762)
+++ trunk/Source/_javascript_Core/runtime/InferredValue.h 2015-04-13 22:57:18 UTC (rev 182763)
@@ -96,15 +96,10 @@
static const unsigned StructureFlags = StructureIsImmortal | Base::StructureFlags;
-private:
- InferredValue(VM&);
- ~InferredValue();
-
- JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const FireDetail&);
- JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const char* reason);
-
// We could have used Weak<>. But we want arbitrary JSValues, not just cells. It's also somewhat
// convenient to have eager notification of death.
+ //
+ // Also note that this should be a private class, but it isn't because Windows.
class ValueCleanup : public UnconditionalFinalizer {
WTF_MAKE_FAST_ALLOCATED;
@@ -119,6 +114,13 @@
InferredValue* m_owner;
};
+private:
+ InferredValue(VM&);
+ ~InferredValue();
+
+ JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const FireDetail&);
+ JS_EXPORT_PRIVATE void notifyWriteSlow(VM&, JSValue, const char* reason);
+
friend class ValueCleanup;
InlineWatchpointSet m_set;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
