Title: [183147] trunk/Source/WebKit/mac
- Revision
- 183147
- Author
- [email protected]
- Date
- 2015-04-22 15:43:41 -0700 (Wed, 22 Apr 2015)
Log Message
[Mac] Device picker menu is positioned incorrectly in WK1
https://bugs.webkit.org/show_bug.cgi?id=144049
<rdar://problem/20493101>
Reviewed by Dean Jackson.
* WebView/WebView.mm:
(-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
window coordinates so don't call convertRect:toView:nil.
Modified Paths
Diff
Modified: trunk/Source/WebKit/mac/ChangeLog (183146 => 183147)
--- trunk/Source/WebKit/mac/ChangeLog 2015-04-22 22:43:32 UTC (rev 183146)
+++ trunk/Source/WebKit/mac/ChangeLog 2015-04-22 22:43:41 UTC (rev 183147)
@@ -1,3 +1,15 @@
+2015-04-22 Eric Carlson <[email protected]>
+
+ [Mac] Device picker menu is positioned incorrectly in WK1
+ https://bugs.webkit.org/show_bug.cgi?id=144049
+ <rdar://problem/20493101>
+
+ Reviewed by Dean Jackson.
+
+ * WebView/WebView.mm:
+ (-[WebView _showPlaybackTargetPicker:location:hasVideo:]): Mouse location is already in
+ window coordinates so don't call convertRect:toView:nil.
+
2015-04-21 Brent Fulgham <[email protected]>
Extend action menus to support PDF
Modified: trunk/Source/WebKit/mac/WebView/WebView.mm (183146 => 183147)
--- trunk/Source/WebKit/mac/WebView/WebView.mm 2015-04-22 22:43:32 UTC (rev 183146)
+++ trunk/Source/WebKit/mac/WebView/WebView.mm 2015-04-22 22:43:41 UTC (rev 183147)
@@ -8685,8 +8685,7 @@
if (!_private->page)
return;
- NSRect rectInWindowCoordinates = [self convertRect:[self _convertRectFromRootView:NSMakeRect(location.x(), location.y(), 0, 0)] toView:nil];
- NSRect rectInScreenCoordinates = [self.window convertRectToScreen:rectInWindowCoordinates];
+ NSRect rectInScreenCoordinates = [self.window convertRectToScreen:NSMakeRect(location.x(), location.y(), 0, 0)];
[self _devicePicker]->showPlaybackTargetPicker(clientId, rectInScreenCoordinates, hasVideo);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
