Title: [183168] trunk/Source/WebCore
- Revision
- 183168
- Author
- [email protected]
- Date
- 2015-04-22 21:38:11 -0700 (Wed, 22 Apr 2015)
Log Message
Volume slider appears/doesn't appear at the wrong times.
https://bugs.webkit.org/show_bug.cgi?id=144072.
<rdar://problem/20576145>
Reviewed by Dean Jackson.
Set background divs to match volume box dimensions.
* Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-volume-slider-container-background):
(audio::-webkit-media-controls-volume-slider-container-tint):
Draw the volume slider immediately on mousing over the mute box.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.createControls):
(Controller.prototype.handleMuteBoxOver):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183167 => 183168)
--- trunk/Source/WebCore/ChangeLog 2015-04-23 04:31:45 UTC (rev 183167)
+++ trunk/Source/WebCore/ChangeLog 2015-04-23 04:38:11 UTC (rev 183168)
@@ -1,3 +1,21 @@
+2015-04-22 Roger Fong <[email protected]>
+
+ Volume slider appears/doesn't appear at the wrong times.
+ https://bugs.webkit.org/show_bug.cgi?id=144072.
+ <rdar://problem/20576145>
+
+ Reviewed by Dean Jackson.
+
+ Set background divs to match volume box dimensions.
+ * Modules/mediacontrols/mediaControlsApple.css:
+ (audio::-webkit-media-controls-volume-slider-container-background):
+ (audio::-webkit-media-controls-volume-slider-container-tint):
+
+ Draw the volume slider immediately on mousing over the mute box.
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.createControls):
+ (Controller.prototype.handleMuteBoxOver):
+
2015-04-22 Jer Noble <[email protected]>
[Mac][MediaSource] Crash when SourceBuffer::provideMediaData() is called re-entrantly.
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css (183167 => 183168)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2015-04-23 04:31:45 UTC (rev 183167)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.css 2015-04-23 04:38:11 UTC (rev 183168)
@@ -244,8 +244,8 @@
position: absolute;
left: 0;
top: 0;
- width: 116px;
- height: 63px;
+ width: 100%;
+ height: 100%;
border-bottom-right-radius: 4px;
border-top-right-radius: 4px;
background-color: rgba(30, 30, 30, 0.45);
@@ -257,8 +257,8 @@
position: absolute;
left: 0;
top: 0;
- height: 63px;
- width: 116px;
+ height: 100%;
+ width: 100%;
border-bottom-right-radius: 4px;
border-top-right-radius: 4px;
background-color: rgb(41, 41, 41);
@@ -269,8 +269,6 @@
video::-webkit-media-controls-panel .mute-box:hover .volume-box,
video::-webkit-media-controls-panel .volume-box:hover,
video::-webkit-media-controls-panel .volume-box:active,
-video::-webkit-media-controls-volume-slider-container-background,
-video::-webkit-media-controls-volume-slider-container-tint,
audio::-webkit-media-controls-panel .mute-box:hover .volume-box,
audio::-webkit-media-controls-panel .volume-box:hover,
audio::-webkit-media-controls-panel .volume-box:active {
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (183167 => 183168)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-04-23 04:31:45 UTC (rev 183167)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-04-23 04:38:11 UTC (rev 183168)
@@ -396,6 +396,7 @@
var muteBox = this.controls.muteBox = document.createElement('div');
muteBox.classList.add(this.ClassNames.muteBox);
+ this.listenFor(muteBox, 'mouseover', this.handleMuteBoxOver);
var muteButton = this.controls.muteButton = document.createElement('button');
muteButton.setAttribute('pseudo', '-webkit-media-controls-mute-button');
@@ -926,6 +927,11 @@
return true;
},
+ handleMuteBoxOver: function(event)
+ {
+ this.drawVolumeBackground();
+ },
+
handleMinButtonClicked: function(event)
{
if (this.video.muted) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
