Title: [183225] trunk/Source/WebCore
- Revision
- 183225
- Author
- [email protected]
- Date
- 2015-04-23 16:01:30 -0700 (Thu, 23 Apr 2015)
Log Message
Update media timeline controls when video is paused..
https://bugs.webkit.org/show_bug.cgi?id=144122.
<rdar://problem/20422927>
Reviewed by Dean Jackson.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.drawTimelineBackground): Use timelineWidth because offsetWidth is 0 when display: none.
(Controller.prototype.setPlaying): Show controls when pausing.
(Controller.prototype.showControls): Update time and timeline when unhiding controls.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183224 => 183225)
--- trunk/Source/WebCore/ChangeLog 2015-04-23 22:54:02 UTC (rev 183224)
+++ trunk/Source/WebCore/ChangeLog 2015-04-23 23:01:30 UTC (rev 183225)
@@ -1,3 +1,16 @@
+2015-04-23 Roger Fong <[email protected]>
+
+ Update media timeline controls when video is paused..
+ https://bugs.webkit.org/show_bug.cgi?id=144122.
+ <rdar://problem/20422927>
+
+ Reviewed by Dean Jackson.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.drawTimelineBackground): Use timelineWidth because offsetWidth is 0 when display: none.
+ (Controller.prototype.setPlaying): Show controls when pausing.
+ (Controller.prototype.showControls): Update time and timeline when unhiding controls.
+
2015-04-23 Simon Fraser <[email protected]>
Changing TiledBacking velocity should schedule a tile revalidation
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (183224 => 183225)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-04-23 22:54:02 UTC (rev 183224)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-04-23 23:01:30 UTC (rev 183225)
@@ -1131,8 +1131,8 @@
drawTimelineBackground: function() {
var dpr = window.devicePixelRatio;
- var width = this.controls.timeline.offsetWidth * dpr;
- var height = this.controls.timeline.offsetHeight * dpr;
+ var width = this.timelineWidth * dpr;
+ var height = this.timelineHeight * dpr;
if (!width || !height)
return;
@@ -1307,6 +1307,7 @@
this.controls.panelBackground.classList.add(this.ClassNames.paused);
this.controls.playButton.classList.add(this.ClassNames.paused);
this.controls.playButton.setAttribute('aria-label', this.UIString('Play'));
+ this.showControls();
} else {
this.controls.panel.classList.remove(this.ClassNames.paused);
if (this.controls.panelBackground)
@@ -1321,9 +1322,10 @@
{
this.setNeedsTimelineMetricsUpdate();
- this.updateTime();
+ this.updateTime(true);
this.updateProgress(true);
this.drawVolumeBackground();
+ this.drawTimelineBackground();
this.controls.panel.classList.add(this.ClassNames.show);
this.controls.panel.classList.remove(this.ClassNames.hidden);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
