Title: [183258] trunk/Source/WebKit2
- Revision
- 183258
- Author
- [email protected]
- Date
- 2015-04-24 03:21:13 -0700 (Fri, 24 Apr 2015)
Log Message
Unreviewed. Remove incorrect assert after r183189.
In this case the assert was already there, but it's incorrect
because we are handling uninitialized attachments below in the
same function, and also when sending messages. So, if it's ok to
send uninitialized attachments, it's ok to receive them. This
didn't fail before r183189, because we were only invaliding the
attachments by setting the file descriptor to -1, and they were
handled as null attachments. After r183189, the move operator
resets the moved attachment leaving it uninitialized again.
* Platform/IPC/unix/ConnectionUnix.cpp:
(IPC::Connection::processMessage):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183257 => 183258)
--- trunk/Source/WebKit2/ChangeLog 2015-04-24 07:41:20 UTC (rev 183257)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-24 10:21:13 UTC (rev 183258)
@@ -1,5 +1,21 @@
2015-04-24 Carlos Garcia Campos <[email protected]>
+ Unreviewed. Remove incorrect assert after r183189.
+
+ In this case the assert was already there, but it's incorrect
+ because we are handling uninitialized attachments below in the
+ same function, and also when sending messages. So, if it's ok to
+ send uninitialized attachments, it's ok to receive them. This
+ didn't fail before r183189, because we were only invaliding the
+ attachments by setting the file descriptor to -1, and they were
+ handled as null attachments. After r183189, the move operator
+ resets the moved attachment leaving it uninitialized again.
+
+ * Platform/IPC/unix/ConnectionUnix.cpp:
+ (IPC::Connection::processMessage):
+
+2015-04-24 Carlos Garcia Campos <[email protected]>
+
[SOUP] Use a webkit subdirectory for the disk cache
https://bugs.webkit.org/show_bug.cgi?id=144048
Modified: trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp (183257 => 183258)
--- trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp 2015-04-24 07:41:20 UTC (rev 183257)
+++ trunk/Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp 2015-04-24 10:21:13 UTC (rev 183258)
@@ -187,7 +187,6 @@
break;
case Attachment::Uninitialized:
default:
- ASSERT_NOT_REACHED();
break;
}
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
