Title: [183268] trunk/Source
- Revision
- 183268
- Author
- [email protected]
- Date
- 2015-04-24 11:02:30 -0700 (Fri, 24 Apr 2015)
Log Message
REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
https://bugs.webkit.org/show_bug.cgi?id=144150
Reviewed by Brian Burg.
Source/WebInspectorUI:
* UserInterface/Protocol/InspectorFrontendAPI.js:
(InspectorFrontendAPI.setTimelineProfilingEnabled): Change !== to === when
checking enabled to isCapturing().
Source/WebKit2:
* WebProcess/WebPage/WebInspectorUI.cpp:
(WebKit::WebInspectorUI::evaluateCommandOnLoad): Properly treat bools as literals
instead of strings by not using the string version of evaluateCommandOnLoad.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183267 => 183268)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-24 17:26:08 UTC (rev 183267)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-24 18:02:30 UTC (rev 183268)
@@ -1,3 +1,14 @@
+2015-04-24 Timothy Hatcher <[email protected]>
+
+ REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
+ https://bugs.webkit.org/show_bug.cgi?id=144150
+
+ Reviewed by Brian Burg.
+
+ * UserInterface/Protocol/InspectorFrontendAPI.js:
+ (InspectorFrontendAPI.setTimelineProfilingEnabled): Change !== to === when
+ checking enabled to isCapturing().
+
2015-04-23 Brian J. Burg <[email protected]>
Web Inspector: run a customizable bootstrap function after the UI has fully loaded
Modified: trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js (183267 => 183268)
--- trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2015-04-24 17:26:08 UTC (rev 183267)
+++ trunk/Source/WebInspectorUI/UserInterface/Protocol/InspectorFrontendAPI.js 2015-04-24 18:02:30 UTC (rev 183268)
@@ -44,7 +44,7 @@
setTimelineProfilingEnabled: function(enabled)
{
- if (WebInspector.timelineManager.isCapturing() !== enabled)
+ if (WebInspector.timelineManager.isCapturing() === enabled)
return;
if (enabled) {
Modified: trunk/Source/WebKit2/ChangeLog (183267 => 183268)
--- trunk/Source/WebKit2/ChangeLog 2015-04-24 17:26:08 UTC (rev 183267)
+++ trunk/Source/WebKit2/ChangeLog 2015-04-24 18:02:30 UTC (rev 183268)
@@ -1,3 +1,14 @@
+2015-04-24 Timothy Hatcher <[email protected]>
+
+ REGRESSION: Web Inspector: Start Timeline Recording in Develop menu broken
+ https://bugs.webkit.org/show_bug.cgi?id=144150
+
+ Reviewed by Brian Burg.
+
+ * WebProcess/WebPage/WebInspectorUI.cpp:
+ (WebKit::WebInspectorUI::evaluateCommandOnLoad): Properly treat bools as literals
+ instead of strings by not using the string version of evaluateCommandOnLoad.
+
2015-04-23 Anders Carlsson <[email protected]>
Add headerdocs for WKWebsiteDataRecord and WKWebsiteDataStore
Modified: trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp (183267 => 183268)
--- trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-04-24 17:26:08 UTC (rev 183267)
+++ trunk/Source/WebKit2/WebProcess/WebPage/WebInspectorUI.cpp 2015-04-24 18:02:30 UTC (rev 183268)
@@ -256,7 +256,7 @@
void WebInspectorUI::evaluateCommandOnLoad(const String& command, bool argument)
{
- evaluateCommandOnLoad(command, ASCIILiteral(argument ? "true" : "false"));
+ evaluateExpressionOnLoad(makeString("InspectorFrontendAPI.dispatch([\"", command, "\", ", ASCIILiteral(argument ? "true" : "false"), "])"));
}
void WebInspectorUI::evaluateExpressionOnLoad(const String& _expression_)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
