Title: [183321] trunk/Source/WebInspectorUI/ChangeLog
- Revision
- 183321
- Author
- [email protected]
- Date
- 2015-04-25 18:14:13 -0700 (Sat, 25 Apr 2015)
Log Message
Web Inspector: Make closing ContentViews more leak proof
https://bugs.webkit.org/show_bug.cgi?id=144200
Remove all listeners on the target objects in close that match the this object.
This makes things more foolproof when something changes or a new listener is
added to the same object. TimelineRecordingContentView also had a leak where
TimelineManager and DebuggerManager listeners were not being removed.
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ApplicationCacheFrameContentView.js:
(WebInspector.ApplicationCacheFrameContentView.prototype.closed):
* UserInterface/Views/ClusterContentView.js:
(WebInspector.ClusterContentView.prototype.closed):
* UserInterface/Views/ContentFlowDOMTreeContentView.js:
(WebInspector.ContentFlowDOMTreeContentView.prototype.closed):
* UserInterface/Views/FrameDOMTreeContentView.js:
(WebInspector.FrameDOMTreeContentView.prototype.closed):
* UserInterface/Views/ResourceContentView.js:
(WebInspector.ResourceContentView.prototype.closed):
* UserInterface/Views/TextResourceContentView.js:
(WebInspector.TextResourceContentView.prototype.closed):
* UserInterface/Views/TimelineRecordingContentView.js:
(WebInspector.TimelineRecordingContentView.prototype.closed):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183320 => 183321)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-26 01:08:59 UTC (rev 183320)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-26 01:14:13 UTC (rev 183321)
@@ -8,6 +8,33 @@
added to the same object. TimelineRecordingContentView also had a leak where
TimelineManager and DebuggerManager listeners were not being removed.
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ApplicationCacheFrameContentView.js:
+ (WebInspector.ApplicationCacheFrameContentView.prototype.closed):
+ * UserInterface/Views/ClusterContentView.js:
+ (WebInspector.ClusterContentView.prototype.closed):
+ * UserInterface/Views/ContentFlowDOMTreeContentView.js:
+ (WebInspector.ContentFlowDOMTreeContentView.prototype.closed):
+ * UserInterface/Views/FrameDOMTreeContentView.js:
+ (WebInspector.FrameDOMTreeContentView.prototype.closed):
+ * UserInterface/Views/ResourceContentView.js:
+ (WebInspector.ResourceContentView.prototype.closed):
+ * UserInterface/Views/TextResourceContentView.js:
+ (WebInspector.TextResourceContentView.prototype.closed):
+ * UserInterface/Views/TimelineRecordingContentView.js:
+ (WebInspector.TimelineRecordingContentView.prototype.closed):
+
+2015-04-25 Timothy Hatcher <[email protected]>
+
+ Web Inspector: Make closing ContentViews more leak proof
+ https://bugs.webkit.org/show_bug.cgi?id=144200
+
+ Remove all listeners on the target objects in close that match the this object.
+ This makes things more foolproof when something changes or a new listener is
+ added to the same object. TimelineRecordingContentView also had a leak where
+ TimelineManager and DebuggerManager listeners were not being removed.
+
Reviewed by Darin Adler.
* UserInterface/Views/ApplicationCacheFrameContentView.js:
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
