Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183325 => 183326)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-26 01:17:57 UTC (rev 183326)
@@ -1,5 +1,25 @@
2015-04-22 Timothy Hatcher <[email protected]>
+ Web Inspector: Remove allowedNavigationSidebarPanels, it isn't needed
+ https://bugs.webkit.org/show_bug.cgi?id=144056
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ApplicationCacheFrameContentView.js:
+ * UserInterface/Views/ContentView.js:
+ * UserInterface/Views/CookieStorageContentView.js:
+ * UserInterface/Views/DOMStorageContentView.js:
+ * UserInterface/Views/DOMTreeContentView.js:
+ * UserInterface/Views/DatabaseContentView.js:
+ * UserInterface/Views/DatabaseTableContentView.js:
+ * UserInterface/Views/FontResourceContentView.js:
+ * UserInterface/Views/FrameDOMTreeContentView.js:
+ * UserInterface/Views/LogContentView.js:
+ * UserInterface/Views/ResourceClusterContentView.js:
+ * UserInterface/Views/TimelineRecordingContentView.js:
+
+2015-04-22 Timothy Hatcher <[email protected]>
+
Web Inspector: Support passing extra arguments to ContentViews during construction
https://bugs.webkit.org/show_bug.cgi?id=144055
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ApplicationCacheFrameContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -53,11 +53,6 @@
WebInspector.ApplicationCacheFrameContentView.prototype = {
constructor: WebInspector.ApplicationCacheFrameContentView,
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
shown: function()
{
this._maybeUpdate();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -176,12 +176,6 @@
return [];
},
- get allowedNavigationSidebarPanels()
- {
- // Allow any navigation sidebar panel.
- return [];
- },
-
get element()
{
return this._element;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/CookieStorageContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -39,11 +39,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
update: function()
{
function callback(error, cookies)
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMStorageContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -50,11 +50,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
reset: function()
{
this.representedObject.getEntries(function(error, entries) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -79,11 +79,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
get navigationItems()
{
return [this._showsShadowDOMButtonNavigationItem, this._compositingBordersButtonNavigationItem, this._paintFlashingButtonNavigationItem];
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -50,11 +50,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
shown: function()
{
this.prompt.shown();
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DatabaseTableContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -57,11 +57,6 @@
return [this._refreshButtonNavigationItem];
},
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
update: function()
{
this.representedObject.database.executeSQL("SELECT * FROM \"" + this._escapeTableName(this.representedObject.name) + "\"", this._queryFinished.bind(this), this._queryError.bind(this));
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FontResourceContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -53,14 +53,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- return [
- WebInspector.resourceSidebarPanel.identifier,
- WebInspector.timelineSidebarPanel.identifier
- ];
- },
-
get previewElement()
{
return this._previewElement;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/FrameDOMTreeContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -42,11 +42,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.resourceSidebarPanel.identifier];
- },
-
get domTree()
{
return this._domTree;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -115,11 +115,6 @@
constructor: WebInspector.LogContentView,
// Public
- get allowedNavigationSidebarPanels()
- {
- // Don't show any sidebars when the Console is opened.
- return null;
- },
get navigationItems()
{
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceClusterContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -59,22 +59,6 @@
// Public
- get allowedNavigationSidebarPanels()
- {
- console.assert(this._resource);
-
- switch (this._resource.type) {
- case WebInspector.Resource.Type.Document: // HTML documents may have inline scripts.
- case WebInspector.Resource.Type.Script:
- return [];
- default:
- return [
- WebInspector.resourceSidebarPanel.identifier,
- WebInspector.timelineSidebarPanel.identifier
- ];
- }
- },
-
get resource()
{
return this._resource;
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js (183325 => 183326)
--- trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-04-26 01:17:23 UTC (rev 183325)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/TimelineRecordingContentView.js 2015-04-26 01:17:57 UTC (rev 183326)
@@ -110,11 +110,6 @@
this._contentViewContainer.showContentView(this._timelineViewMap.get(timeline));
},
- get allowedNavigationSidebarPanels()
- {
- return [WebInspector.timelineSidebarPanel.identifier];
- },
-
get supportsSplitContentBrowser()
{
// The layout of the overview and split content browser don't work well.
