Title: [183422] trunk/Source/WebInspectorUI
- Revision
- 183422
- Author
- [email protected]
- Date
- 2015-04-27 14:28:57 -0700 (Mon, 27 Apr 2015)
Log Message
Web Inspector: TabContentView closed() isn't being called when a tab is closed / removed
https://bugs.webkit.org/show_bug.cgi?id=144229
Reviewed by Joseph Pecoraro.
* UserInterface/Views/ContentViewContainer.js:
(WebInspector.ContentViewContainer.prototype._disassociateFromContentView):
TabContentViews don't have a representedObject, so returning early and not
calling closed() was not correct.
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183421 => 183422)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-04-27 21:08:35 UTC (rev 183421)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-04-27 21:28:57 UTC (rev 183422)
@@ -1,3 +1,15 @@
+2015-04-27 Timothy Hatcher <[email protected]>
+
+ Web Inspector: TabContentView closed() isn't being called when a tab is closed / removed
+ https://bugs.webkit.org/show_bug.cgi?id=144229
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Views/ContentViewContainer.js:
+ (WebInspector.ContentViewContainer.prototype._disassociateFromContentView):
+ TabContentViews don't have a representedObject, so returning early and not
+ calling closed() was not correct.
+
2015-04-26 Matt Baker <[email protected]>
Web Inspector: Cannot make Timeline time range selection clicking inside Frames Overview
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js (183421 => 183422)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js 2015-04-27 21:08:35 UTC (rev 183421)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ContentViewContainer.js 2015-04-27 21:28:57 UTC (rev 183422)
@@ -447,11 +447,9 @@
contentView._parentContainer = null;
var representedObject = contentView.representedObject;
- if (!representedObject || !representedObject.__contentViews)
- return;
+ if (representedObject && representedObject.__contentViews)
+ representedObject.__contentViews.remove(contentView);
- representedObject.__contentViews.remove(contentView);
-
contentView.closed();
},
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
