Title: [183543] trunk/Tools
- Revision
- 183543
- Author
- [email protected]
- Date
- 2015-04-29 05:43:55 -0700 (Wed, 29 Apr 2015)
Log Message
Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
Latest changes in the inspector UI made this test fail. We were
relying that the sidebar was always visible and the first 'li'
element of the inspector was the one containing the title. This is
no longer true, so better use document title that is not likely
to change.
* TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
(openRemoteDebuggingSession):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (183542 => 183543)
--- trunk/Tools/ChangeLog 2015-04-29 12:10:01 UTC (rev 183542)
+++ trunk/Tools/ChangeLog 2015-04-29 12:43:55 UTC (rev 183543)
@@ -1,3 +1,16 @@
+2015-04-29 Carlos Garcia Campos <[email protected]>
+
+ Unreviewed. Fix /webkit2/WebKitWebInspectorServer/test-open-debugging-session.
+
+ Latest changes in the inspector UI made this test fail. We were
+ relying that the sidebar was always visible and the first 'li'
+ element of the inspector was the one containing the title. This is
+ no longer true, so better use document title that is not likely
+ to change.
+
+ * TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp:
+ (openRemoteDebuggingSession):
+
2015-04-29 Andres Gomez <[email protected]>
Unreviewed. Re-sorted my contributor's mails to help bugzilla on showing the proper one.
Modified: trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp (183542 => 183543)
--- trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp 2015-04-29 12:10:01 UTC (rev 183542)
+++ trunk/Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestInspectorServer.cpp 2015-04-29 12:43:55 UTC (rev 183543)
@@ -237,12 +237,12 @@
test->loadURI(resolvedURL.utf8().data());
test->waitUntilLoadFinished();
- _javascript_Result = test->runJavaScriptAndWaitUntilFinished("window.document.getElementsByTagName('li')[0].title", &error.outPtr());
+ _javascript_Result = test->runJavaScriptAndWaitUntilFinished("document.title", &error.outPtr());
g_assert(_javascript_Result);
g_assert(!error.get());
GUniquePtr<char> title(WebViewTest::_javascript_ResultToCString(_javascript_Result));
- g_assert_cmpstr(title.get(), ==, "http://127.0.0.1:2999/");
+ g_assert_cmpstr(title.get(), ==, "127.0.0.1");
}
static void sendIncompleteRequest(InspectorServerTest* test, gconstpointer)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
