Title: [183590] trunk/Source/_javascript_Core
- Revision
- 183590
- Author
- [email protected]
- Date
- 2015-04-29 16:46:18 -0700 (Wed, 29 Apr 2015)
Log Message
Gracefully handle missing auto pause key on remote inspector setup
https://bugs.webkit.org/show_bug.cgi?id=144411
Patch by Joseph Pecoraro <[email protected]> on 2015-04-29
Reviewed by Timothy Hatcher.
* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::receivedSetupMessage):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183589 => 183590)
--- trunk/Source/_javascript_Core/ChangeLog 2015-04-29 23:22:39 UTC (rev 183589)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-04-29 23:46:18 UTC (rev 183590)
@@ -1,5 +1,15 @@
2015-04-29 Joseph Pecoraro <[email protected]>
+ Gracefully handle missing auto pause key on remote inspector setup
+ https://bugs.webkit.org/show_bug.cgi?id=144411
+
+ Reviewed by Timothy Hatcher.
+
+ * inspector/remote/RemoteInspector.mm:
+ (Inspector::RemoteInspector::receivedSetupMessage):
+
+2015-04-29 Joseph Pecoraro <[email protected]>
+
NodeList has issues with Symbol and empty string
https://bugs.webkit.org/show_bug.cgi?id=144310
Modified: trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm (183589 => 183590)
--- trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2015-04-29 23:22:39 UTC (rev 183589)
+++ trunk/Source/_javascript_Core/inspector/remote/RemoteInspector.mm 2015-04-29 23:46:18 UTC (rev 183590)
@@ -572,7 +572,12 @@
RemoteInspectorDebuggableInfo debuggableInfo = it->value.second;
RefPtr<RemoteInspectorDebuggableConnection> connection = adoptRef(new RemoteInspectorDebuggableConnection(debuggable, connectionIdentifier, sender, debuggableInfo.type));
bool isAutomaticInspection = m_automaticInspectionCandidateIdentifier == debuggable->identifier();
- bool automaticallyPause = [[userInfo objectForKey:WIRAutomaticallyPause] boolValue];
+
+ bool automaticallyPause = false;
+ NSNumber *automaticallyPauseObject = [userInfo objectForKey:WIRAutomaticallyPause];
+ if ([automaticallyPauseObject isKindOfClass:[NSNumber class]])
+ automaticallyPause = [automaticallyPauseObject boolValue];
+
if (!connection->setup(isAutomaticInspection, automaticallyPause)) {
connection->close();
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
