Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (183713 => 183714)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-02 09:36:12 UTC (rev 183713)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-02 09:41:26 UTC (rev 183714)
@@ -1,5 +1,22 @@
2015-05-02 Timothy Hatcher <[email protected]>
+ Web Inspector: Allow closing and reopening the Resources tab
+ https://bugs.webkit.org/show_bug.cgi?id=144513
+
+ Reviewed by Joseph Pecoraro.
+
+ * UserInterface/Base/Main.js:
+ (WebInspector._updateNewTabButtonState):
+ * UserInterface/Views/NewTabContentView.js:
+ (WebInspector.NewTabContentView):
+ * UserInterface/Views/ResourceSidebarPanel.js:
+ (WebInspector.ResourceSidebarPanel):
+ (WebInspector.ResourceSidebarPanel.prototype.closed):
+ * UserInterface/Views/ResourcesTabContentView.js:
+ (WebInspector.ResourcesTabContentView):
+
+2015-05-02 Timothy Hatcher <[email protected]>
+
Web Inspector: REGRESSION: Resources section doesn't update after changes are made to a local file
https://bugs.webkit.org/show_bug.cgi?id=144512
Modified: trunk/Source/WebInspectorUI/UserInterface/Base/Main.js (183713 => 183714)
--- trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-05-02 09:36:12 UTC (rev 183713)
+++ trunk/Source/WebInspectorUI/UserInterface/Base/Main.js 2015-05-02 09:41:26 UTC (rev 183714)
@@ -431,7 +431,7 @@
WebInspector._updateNewTabButtonState = function(event)
{
var newTabAllowed = this.isNewTabWithTypeAllowed(WebInspector.ConsoleTabContentView.Type) || this.isNewTabWithTypeAllowed(WebInspector.ElementsTabContentView.Type)
- || this.isNewTabWithTypeAllowed(WebInspector.StorageTabContentView.Type);
+ || this.isNewTabWithTypeAllowed(WebInspector.ResourcesTabContentView.Type) || this.isNewTabWithTypeAllowed(WebInspector.StorageTabContentView.Type);
this.tabBar.newTabItem.disabled = !newTabAllowed;
};
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js (183713 => 183714)
--- trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js 2015-05-02 09:36:12 UTC (rev 183713)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/NewTabContentView.js 2015-05-02 09:41:26 UTC (rev 183714)
@@ -31,6 +31,7 @@
var allowedNewTabs = [
{image: "Images/Elements.svg", title: WebInspector.UIString("Elements"), type: WebInspector.ElementsTabContentView.Type},
+ {image: "Images/Resources.svg", title: WebInspector.UIString("Resources"), type: WebInspector.ResourcesTabContentView.Type},
{image: "Images/Storage.svg", title: WebInspector.UIString("Storage"), type: WebInspector.StorageTabContentView.Type},
{image: "Images/Console.svg", title: WebInspector.UIString("Console"), type: WebInspector.ConsoleTabContentView.Type}
];
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js (183713 => 183714)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2015-05-02 09:36:12 UTC (rev 183713)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourceSidebarPanel.js 2015-05-02 09:41:26 UTC (rev 183714)
@@ -47,10 +47,21 @@
if (WebInspector.debuggableType === WebInspector.DebuggableType._javascript_)
this.contentTreeOutline.element.classList.add(WebInspector.NavigationSidebarPanel.HideDisclosureButtonsStyleClassName);
+
+ if (WebInspector.frameResourceManager.mainFrame)
+ this._mainFrameMainResourceDidChange(WebInspector.frameResourceManager.mainFrame);
}
// Public
+ closed()
+ {
+ WebInspector.Frame.removeEventListener(null, null, this);
+ WebInspector.frameResourceManager.removeEventListener(null, null, this);
+ WebInspector.debuggerManager.removeEventListener(null, null, this);
+ WebInspector.notifications.removeEventListener(null, null, this);
+ }
+
showDefaultContentView()
{
if (WebInspector.frameResourceManager.mainFrame) {
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js (183713 => 183714)
--- trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2015-05-02 09:36:12 UTC (rev 183713)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/ResourcesTabContentView.js 2015-05-02 09:41:26 UTC (rev 183714)
@@ -33,9 +33,6 @@
if (WebInspector.layerTreeDetailsSidebarPanel)
detailsSidebarPanels.push(WebInspector.layerTreeDetailsSidebarPanel);
- // FIME: Until ResourceSidebarPanel supports instantiating after inspector launch, disable closing.
- tabBarItem.hideCloseButton = true;
-
WebInspector.ContentBrowserTabContentView.call(this, identifier || "resources", "resources", tabBarItem, WebInspector.ResourceSidebarPanel, detailsSidebarPanels);
};
