Title: [183736] trunk/Source/WebKit2
Revision
183736
Author
[email protected]
Date
2015-05-03 22:16:00 -0700 (Sun, 03 May 2015)

Log Message

Crash in SandboxExtension::consume when uploading iWork -tef documents to iCloud
https://bugs.webkit.org/show_bug.cgi?id=144509
rdar://problem/18731910

Reviewed by Daniel Bates.

No test, because testRunner.beginDragWithFiles doesn't work in WKTR, and making
it work is hard.

* Shared/BlobDataFileReferenceWithSandboxExtension.cpp:
(WebKit::BlobDataFileReferenceWithSandboxExtension::prepareForFileAccess):
(WebKit::BlobDataFileReferenceWithSandboxExtension::revokeFileAccess):

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (183735 => 183736)


--- trunk/Source/WebKit2/ChangeLog	2015-05-04 01:20:48 UTC (rev 183735)
+++ trunk/Source/WebKit2/ChangeLog	2015-05-04 05:16:00 UTC (rev 183736)
@@ -1,3 +1,18 @@
+2015-05-03  Alexey Proskuryakov  <[email protected]>
+
+        Crash in SandboxExtension::consume when uploading iWork -tef documents to iCloud
+        https://bugs.webkit.org/show_bug.cgi?id=144509
+        rdar://problem/18731910
+
+        Reviewed by Daniel Bates.
+
+        No test, because testRunner.beginDragWithFiles doesn't work in WKTR, and making
+        it work is hard.
+
+        * Shared/BlobDataFileReferenceWithSandboxExtension.cpp:
+        (WebKit::BlobDataFileReferenceWithSandboxExtension::prepareForFileAccess):
+        (WebKit::BlobDataFileReferenceWithSandboxExtension::revokeFileAccess):
+
 2015-05-03  Carlos Garcia Campos  <[email protected]>
 
         [GTK][EFL] Unify platform display handling

Modified: trunk/Source/WebKit2/Shared/BlobDataFileReferenceWithSandboxExtension.cpp (183735 => 183736)


--- trunk/Source/WebKit2/Shared/BlobDataFileReferenceWithSandboxExtension.cpp	2015-05-04 01:20:48 UTC (rev 183735)
+++ trunk/Source/WebKit2/Shared/BlobDataFileReferenceWithSandboxExtension.cpp	2015-05-04 05:16:00 UTC (rev 183736)
@@ -42,12 +42,14 @@
 
 void BlobDataFileReferenceWithSandboxExtension::prepareForFileAccess()
 {
-    m_sandboxExtension->consume();
+    if (m_sandboxExtension)
+        m_sandboxExtension->consume();
 }
 
 void BlobDataFileReferenceWithSandboxExtension::revokeFileAccess()
 {
-    m_sandboxExtension->revoke();
+    if (m_sandboxExtension)
+        m_sandboxExtension->revoke();
 }
 
 }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to