Title: [183774] trunk/Source/WebCore
- Revision
- 183774
- Author
- [email protected]
- Date
- 2015-05-04 15:14:33 -0700 (Mon, 04 May 2015)
Log Message
[iOS] Crash in -[WebCALayerHostWrapper resolveBounds]
https://bugs.webkit.org/show_bug.cgi?id=144595
Reviewed by Eric Carlson.
It is possible for a WebCALayorHostWrapper to outlive the WebVideoFullscreenModel to which it refers,
since the model pointer is bare, rather than a RefPtr. The reference to the model must be invalidated
before the model is destroyed.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183773 => 183774)
--- trunk/Source/WebCore/ChangeLog 2015-05-04 21:42:45 UTC (rev 183773)
+++ trunk/Source/WebCore/ChangeLog 2015-05-04 22:14:33 UTC (rev 183774)
@@ -1,3 +1,17 @@
+2015-05-04 Jer Noble <[email protected]>
+
+ [iOS] Crash in -[WebCALayerHostWrapper resolveBounds]
+ https://bugs.webkit.org/show_bug.cgi?id=144595
+
+ Reviewed by Eric Carlson.
+
+ It is possible for a WebCALayorHostWrapper to outlive the WebVideoFullscreenModel to which it refers,
+ since the model pointer is bare, rather than a RefPtr. The reference to the model must be invalidated
+ before the model is destroyed.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal):
+
2015-05-04 Ryosuke Niwa <[email protected]>
Toggling underline or strike through affects each other
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (183773 => 183774)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-05-04 21:42:45 UTC (rev 183773)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-05-04 22:14:33 UTC (rev 183774)
@@ -1159,6 +1159,8 @@
[m_videoLayerContainer setPlayerViewController:nil];
[[m_viewController view] removeFromSuperview];
+ [m_layerHostWrapper setModel:nullptr];
+
m_layerHostWrapper = nil;
m_videoLayer = nil;
m_videoLayerContainer = nil;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
