Title: [183791] trunk/Source/_javascript_Core
- Revision
- 183791
- Author
- [email protected]
- Date
- 2015-05-04 20:51:35 -0700 (Mon, 04 May 2015)
Log Message
Large array shouldn't be slow
https://bugs.webkit.org/show_bug.cgi?id=144617
Rubber stamped by Mark Lam.
* tests/mozilla/js1_5/Array/regress-101964.js: Mozilla may have cared about this being fast a decade ago (or more), but we don't care. We've consistently found that an array implementation that punishes this case to get speed on common-case array accesses is better. This should fix some test failures on the bots.
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (183790 => 183791)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-05 03:35:13 UTC (rev 183790)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-05 03:51:35 UTC (rev 183791)
@@ -1,3 +1,12 @@
+2015-05-04 Filip Pizlo <[email protected]>
+
+ Large array shouldn't be slow
+ https://bugs.webkit.org/show_bug.cgi?id=144617
+
+ Rubber stamped by Mark Lam.
+
+ * tests/mozilla/js1_5/Array/regress-101964.js: Mozilla may have cared about this being fast a decade ago (or more), but we don't care. We've consistently found that an array implementation that punishes this case to get speed on common-case array accesses is better. This should fix some test failures on the bots.
+
2015-05-04 Commit Queue <[email protected]>
Unreviewed, rolling out r183789.
Modified: trunk/Source/_javascript_Core/tests/mozilla/js1_5/Array/regress-101964.js (183790 => 183791)
--- trunk/Source/_javascript_Core/tests/mozilla/js1_5/Array/regress-101964.js 2015-05-05 03:35:13 UTC (rev 183790)
+++ trunk/Source/_javascript_Core/tests/mozilla/js1_5/Array/regress-101964.js 2015-05-05 03:51:35 UTC (rev 183791)
@@ -31,7 +31,7 @@
var summary = 'Performance: truncating even very large arrays should be fast!';
var BIG = 10000000;
var LITTLE = 10;
-var FAST = 50; // array truncation should be 50 ms or less to pass the test
+var FAST = 500; // array truncation should be 50 ms or less to pass the test
var MSG_FAST = 'Truncation took less than ' + FAST + ' ms';
var MSG_SLOW = 'Truncation took ';
var MSG_MS = ' ms';
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
