Title: [183927] trunk/Source/WebCore
- Revision
- 183927
- Author
- [email protected]
- Date
- 2015-05-07 07:12:17 -0700 (Thu, 07 May 2015)
Log Message
[Mac] Playback target isn't set on new element
https://bugs.webkit.org/show_bug.cgi?id=144724
Reviewed by Jer Noble.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Call setShouldPlayToPlaybackTarget
if necessary.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget): Remember
the setting in case we don't have an AVPlayer yet.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183926 => 183927)
--- trunk/Source/WebCore/ChangeLog 2015-05-07 14:03:43 UTC (rev 183926)
+++ trunk/Source/WebCore/ChangeLog 2015-05-07 14:12:17 UTC (rev 183927)
@@ -1,3 +1,17 @@
+2015-05-07 Eric Carlson <[email protected]>
+
+ [Mac] Playback target isn't set on new element
+ https://bugs.webkit.org/show_bug.cgi?id=144724
+
+ Reviewed by Jer Noble.
+
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
+ * platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayer): Call setShouldPlayToPlaybackTarget
+ if necessary.
+ (WebCore::MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget): Remember
+ the setting in case we don't have an AVPlayer yet.
+
2015-05-07 Yoav Weiss <[email protected]>
Fix <script srcset> being loaded by the preloader.
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h (183926 => 183927)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2015-05-07 14:03:43 UTC (rev 183926)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h 2015-05-07 14:12:17 UTC (rev 183927)
@@ -379,6 +379,7 @@
bool m_cachedCanPlayFastReverse;
#if ENABLE(WIRELESS_PLAYBACK_TARGET)
mutable bool m_allowsWirelessVideoPlayback;
+ bool m_shouldPlayToPlaybackTarget { false };
#endif
};
Modified: trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm (183926 => 183927)
--- trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2015-05-07 14:03:43 UTC (rev 183926)
+++ trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm 2015-05-07 14:12:17 UTC (rev 183927)
@@ -946,6 +946,11 @@
[m_avPlayer.get() setAllowsExternalPlayback:m_allowsWirelessVideoPlayback];
#endif
+#if ENABLE(WIRELESS_PLAYBACK_TARGET) && !PLATFORM(IOS)
+ if (m_shouldPlayToPlaybackTarget)
+ setShouldPlayToPlaybackTarget(true);
+#endif
+
if (player()->client().mediaPlayerIsVideo())
createAVPlayerLayer();
@@ -2781,6 +2786,8 @@
void MediaPlayerPrivateAVFoundationObjC::setShouldPlayToPlaybackTarget(bool shouldPlay)
{
+ m_shouldPlayToPlaybackTarget = shouldPlay;
+
if (!m_avPlayer)
return;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
