Title: [183941] trunk/Source/WebKit2
- Revision
- 183941
- Author
- [email protected]
- Date
- 2015-05-07 13:06:13 -0700 (Thu, 07 May 2015)
Log Message
Add PLUGIN_ARCHITECTURE(X11) around m_frameRectInWindowCoordinates in NetscapePlugin.
https://bugs.webkit.org/show_bug.cgi?id=144490
Patch by Sungmann Cho <[email protected]> on 2015-05-07
Reviewed by Darin Adler.
m_frameRectInWindowCoordinates in NetscapePlugin is currently being used only for
the windowed plugins, and the windowed plugins are only supported on X11. So we can
guard it with PLUGIN_ARCHITECTURE(X11).
No new tests, no behavior change.
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183940 => 183941)
--- trunk/Source/WebKit2/ChangeLog 2015-05-07 18:52:59 UTC (rev 183940)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-07 20:06:13 UTC (rev 183941)
@@ -1,3 +1,20 @@
+2015-05-07 Sungmann Cho <[email protected]>
+
+ Add PLUGIN_ARCHITECTURE(X11) around m_frameRectInWindowCoordinates in NetscapePlugin.
+ https://bugs.webkit.org/show_bug.cgi?id=144490
+
+ Reviewed by Darin Adler.
+
+ m_frameRectInWindowCoordinates in NetscapePlugin is currently being used only for
+ the windowed plugins, and the windowed plugins are only supported on X11. So we can
+ guard it with PLUGIN_ARCHITECTURE(X11).
+
+ No new tests, no behavior change.
+
+ * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
+ (WebKit::NetscapePlugin::geometryDidChange):
+ * WebProcess/Plugins/Netscape/NetscapePlugin.h:
+
2015-05-05 Myles C. Maxfield <[email protected]>
Revert "Introducing the Platform Abstraction Layer (PAL)"
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp (183940 => 183941)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2015-05-07 18:52:59 UTC (rev 183940)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.cpp 2015-05-07 20:06:13 UTC (rev 183941)
@@ -760,8 +760,10 @@
m_clipRect = clipRect;
m_pluginToRootViewTransform = pluginToRootViewTransform;
+#if PLUGIN_ARCHITECTURE(X11)
IntPoint frameRectLocationInWindowCoordinates = m_pluginToRootViewTransform.mapPoint(IntPoint());
m_frameRectInWindowCoordinates = IntRect(frameRectLocationInWindowCoordinates, m_pluginSize);
+#endif
platformGeometryDidChange();
Modified: trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h (183940 => 183941)
--- trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2015-05-07 18:52:59 UTC (rev 183940)
+++ trunk/Source/WebKit2/WebProcess/Plugins/Netscape/NetscapePlugin.h 2015-05-07 20:06:13 UTC (rev 183941)
@@ -297,8 +297,9 @@
// A transform that can be used to convert from root view coordinates to plug-in coordinates.
WebCore::AffineTransform m_pluginToRootViewTransform;
- // FIXME: Get rid of these.
+#if PLUGIN_ARCHITECTURE(X11)
WebCore::IntRect m_frameRectInWindowCoordinates;
+#endif
CString m_userAgent;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
