Title: [183949] trunk/Source/WebKit2
- Revision
- 183949
- Author
- [email protected]
- Date
- 2015-05-07 14:45:30 -0700 (Thu, 07 May 2015)
Log Message
Followup fixes to r183936
I neglected to include a few review comments when I landed the patch.
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::checkerState): Remove double semicolons.
(WebKit::updateStateForAllProcessPools): Use range-based-for loop here and
give the function a better name.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled): Use new function name
(WebKit::TextChecker::setGrammarCheckingEnabled):Use new function name
(WebKit::TextChecker::ignoreWord): Fix unused parameter warning.
(WebKit::updateStateForAllContexts): Deleted.
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (183948 => 183949)
--- trunk/Source/WebKit2/ChangeLog 2015-05-07 21:22:35 UTC (rev 183948)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-07 21:45:30 UTC (rev 183949)
@@ -1,3 +1,18 @@
+2015-05-07 Martin Robinson <[email protected]>
+
+ Followup fixes to r183936
+
+ I neglected to include a few review comments when I landed the patch.
+
+ * UIProcess/gtk/TextCheckerGtk.cpp:
+ (WebKit::checkerState): Remove double semicolons.
+ (WebKit::updateStateForAllProcessPools): Use range-based-for loop here and
+ give the function a better name.
+ (WebKit::TextChecker::setContinuousSpellCheckingEnabled): Use new function name
+ (WebKit::TextChecker::setGrammarCheckingEnabled):Use new function name
+ (WebKit::TextChecker::ignoreWord): Fix unused parameter warning.
+ (WebKit::updateStateForAllContexts): Deleted.
+
2015-05-07 Michael Catanzaro <[email protected]>
[GTK] Checks for DEVELOPMENT_BUILD are all wrong
Modified: trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp (183948 => 183949)
--- trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp 2015-05-07 21:22:35 UTC (rev 183948)
+++ trunk/Source/WebKit2/UIProcess/gtk/TextCheckerGtk.cpp 2015-05-07 21:45:30 UTC (rev 183949)
@@ -63,8 +63,8 @@
static TextCheckerState textCheckerState;
static std::once_flag onceFlag;
std::call_once(onceFlag, [] {
- textCheckerState.isContinuousSpellCheckingEnabled = false;;
- textCheckerState.isGrammarCheckingEnabled = false;;
+ textCheckerState.isContinuousSpellCheckingEnabled = false;
+ textCheckerState.isGrammarCheckingEnabled = false;
});
return textCheckerState;
@@ -75,11 +75,10 @@
return checkerState();
}
-static void updateStateForAllContexts()
+static void updateStateForAllProcessPools()
{
- const Vector<WebProcessPool*>& contexts = WebProcessPool::allProcessPools();
- for (size_t i = 0; i < contexts.size(); ++i)
- contexts[i]->textCheckerStateChanged();
+ for (const auto& processPool : WebProcessPool::allProcessPools())
+ processPool->textCheckerStateChanged();
}
bool TextChecker::isContinuousSpellCheckingAllowed()
@@ -92,7 +91,7 @@
if (checkerState().isContinuousSpellCheckingEnabled == isContinuousSpellCheckingEnabled)
return;
checkerState().isContinuousSpellCheckingEnabled = isContinuousSpellCheckingEnabled;
- updateStateForAllContexts();
+ updateStateForAllProcessPools();
}
void TextChecker::setGrammarCheckingEnabled(bool isGrammarCheckingEnabled)
@@ -100,7 +99,7 @@
if (checkerState().isGrammarCheckingEnabled == isGrammarCheckingEnabled)
return;
checkerState().isGrammarCheckingEnabled = isGrammarCheckingEnabled;
- updateStateForAllContexts();
+ updateStateForAllProcessPools();
}
void TextChecker::continuousSpellCheckingEnabledStateChanged(bool enabled)
@@ -160,7 +159,7 @@
enchantTextChecker().learnWord(word);
}
-void TextChecker::ignoreWord(int64_t spellDocumentTag, const String& word)
+void TextChecker::ignoreWord(int64_t /* spellDocumentTag */, const String& word)
{
enchantTextChecker().ignoreWord(word);
}
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
