Title: [183981] trunk/Source/WebCore
- Revision
- 183981
- Author
- [email protected]
- Date
- 2015-05-07 23:13:02 -0700 (Thu, 07 May 2015)
Log Message
Add first-letter assert exception in RenderButton::setupInnerStyle().
https://bugs.webkit.org/show_bug.cgi?id=140517OB
Patch by Hyungwook Lee <[email protected]> on 2015-05-07
Reviewed by Darin Adler.
StyleResolver references inner block's render style temporary in
RenderBlock::styleDidChange() when we have first-letter css pseudo
element.
* rendering/RenderButton.cpp:
(WebCore::RenderButton::setupInnerStyle):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (183980 => 183981)
--- trunk/Source/WebCore/ChangeLog 2015-05-08 06:01:17 UTC (rev 183980)
+++ trunk/Source/WebCore/ChangeLog 2015-05-08 06:13:02 UTC (rev 183981)
@@ -1,3 +1,17 @@
+2015-05-07 Hyungwook Lee <[email protected]>
+
+ Add first-letter assert exception in RenderButton::setupInnerStyle().
+ https://bugs.webkit.org/show_bug.cgi?id=140517OB
+
+ Reviewed by Darin Adler.
+
+ StyleResolver references inner block's render style temporary in
+ RenderBlock::styleDidChange() when we have first-letter css pseudo
+ element.
+
+ * rendering/RenderButton.cpp:
+ (WebCore::RenderButton::setupInnerStyle):
+
2015-05-07 Chris Dumez <[email protected]>
Unreviewed, fix build after r183970.
Modified: trunk/Source/WebCore/rendering/RenderButton.cpp (183980 => 183981)
--- trunk/Source/WebCore/rendering/RenderButton.cpp 2015-05-08 06:01:17 UTC (rev 183980)
+++ trunk/Source/WebCore/rendering/RenderButton.cpp 2015-05-08 06:13:02 UTC (rev 183981)
@@ -127,7 +127,7 @@
void RenderButton::setupInnerStyle(RenderStyle* innerStyle)
{
- ASSERT(innerStyle->refCount() == 1);
+ ASSERT(style().hasPseudoStyle(FIRST_LETTER) || innerStyle->refCount() == 1);
// RenderBlock::createAnonymousBlock creates a new RenderStyle, so this is
// safe to modify.
// FIXME: I don't see how the comment above is accurate when this is called
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
