Title: [183995] trunk
- Revision
- 183995
- Author
- [email protected]
- Date
- 2015-05-08 09:09:42 -0700 (Fri, 08 May 2015)
Log Message
[GTK] WTR doesn't correctly handle the Escape key
https://bugs.webkit.org/show_bug.cgi?id=144788
Reviewed by Martin Robinson.
Tools:
Correctly handle 0x001B character code in GTK+ event sender to be
recognized as Escape key, because gdk_unicode_to_keyval() doesn't
handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
to dismiss popup menus.
Fixes editing/selection/5354455-1.html.
* WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
(WTR::getGDKKeySymForKeyRef):
LayoutTests:
Unskip editing/selection/5354455-1.html.
* platform/gtk/TestExpectations:
Modified Paths
Diff
Modified: trunk/LayoutTests/ChangeLog (183994 => 183995)
--- trunk/LayoutTests/ChangeLog 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/LayoutTests/ChangeLog 2015-05-08 16:09:42 UTC (rev 183995)
@@ -1,3 +1,14 @@
+2015-05-08 Carlos Garcia Campos <[email protected]>
+
+ [GTK] WTR doesn't correctly handle the Escape key
+ https://bugs.webkit.org/show_bug.cgi?id=144788
+
+ Reviewed by Martin Robinson.
+
+ Unskip editing/selection/5354455-1.html.
+
+ * platform/gtk/TestExpectations:
+
2015-05-08 Hyungwook Lee <[email protected]>
[Win] Unskip passing test case after r183981
Modified: trunk/LayoutTests/platform/gtk/TestExpectations (183994 => 183995)
--- trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/LayoutTests/platform/gtk/TestExpectations 2015-05-08 16:09:42 UTC (rev 183995)
@@ -1443,7 +1443,6 @@
webkit.org/b/63706 editing/pasteboard/drag-list-item.html [ Failure ]
# WebKit2 needs testRunner.setEditingBehaviour and other issues.
-webkit.org/b/40601 editing/selection/5354455-1.html [ Failure ]
Bug(GTK) editing/selection/extend-after-mouse-selection.html [ Failure ]
# WebKit2 needs textInputController.selectedRange
Modified: trunk/Tools/ChangeLog (183994 => 183995)
--- trunk/Tools/ChangeLog 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/Tools/ChangeLog 2015-05-08 16:09:42 UTC (rev 183995)
@@ -1,5 +1,22 @@
2015-05-08 Carlos Garcia Campos <[email protected]>
+ [GTK] WTR doesn't correctly handle the Escape key
+ https://bugs.webkit.org/show_bug.cgi?id=144788
+
+ Reviewed by Martin Robinson.
+
+ Correctly handle 0x001B character code in GTK+ event sender to be
+ recognized as Escape key, because gdk_unicode_to_keyval() doesn't
+ handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
+ to dismiss popup menus.
+
+ Fixes editing/selection/5354455-1.html.
+
+ * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+ (WTR::getGDKKeySymForKeyRef):
+
+2015-05-08 Carlos Garcia Campos <[email protected]>
+
[GTK] Expose allowFileAccessFromFileURLs setting to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=144748
Modified: trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (183994 => 183995)
--- trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2015-05-08 15:12:50 UTC (rev 183994)
+++ trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp 2015-05-08 16:09:42 UTC (rev 183995)
@@ -277,6 +277,8 @@
return GDK_KEY_Tab;
if (charCode == '\x8')
return GDK_KEY_BackSpace;
+ if (charCode == 0x001B)
+ return GDK_KEY_Escape;
if (WTF::isASCIIUpper(charCode))
*modifiers |= GDK_SHIFT_MASK;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
