Title: [184060] trunk
Revision
184060
Author
[email protected]
Date
2015-05-10 17:57:01 -0700 (Sun, 10 May 2015)

Log Message

[GTK] fast/events/page-visibility-transition-test.html is timing out
https://bugs.webkit.org/show_bug.cgi?id=114789

Reviewed by Darin Adler.

Tools:

* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::setHidden): Map and unmap the WebView when the harness
requests visibility changes.

LayoutTests:

* platform/gtk/TestExpectations: Unskip failing tests.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (184059 => 184060)


--- trunk/LayoutTests/ChangeLog	2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/LayoutTests/ChangeLog	2015-05-11 00:57:01 UTC (rev 184060)
@@ -1,3 +1,12 @@
+2015-05-10  Martin Robinson  <[email protected]>
+
+        [GTK] fast/events/page-visibility-transition-test.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=114789
+
+        Reviewed by Darin Adler.
+
+        * platform/gtk/TestExpectations: Unskip failing tests.
+
 2015-05-10  Chris Fleizach  <[email protected]>
 
         AX: Don't expose elements as data tables just because they use display: table

Modified: trunk/LayoutTests/platform/gtk/TestExpectations (184059 => 184060)


--- trunk/LayoutTests/platform/gtk/TestExpectations	2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/LayoutTests/platform/gtk/TestExpectations	2015-05-11 00:57:01 UTC (rev 184060)
@@ -2270,12 +2270,6 @@
 webkit.org/b/144765 fast/events/touch/touch-slider-no-js-touch-listener.html [ Failure ]
 webkit.org/b/144765 fast/events/touch/touch-inside-iframe.html [ Timeout ]
 
-# Need support for adjusting page visibility in the test harness.
-webkit.org/b/114789 fast/events/page-visibility-iframe-delete-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-iframe-move-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-iframe-propagation-test.html [ Timeout ]
-webkit.org/b/114789 fast/events/page-visibility-transition-test.html [ Timeout ]
-
 webkit.org/b/144763 fast/events/scroll-in-scaled-page-with-overflow-hidden.html
 
 #////////////////////////////////////////////////////////////////////////////////////////

Modified: trunk/Tools/ChangeLog (184059 => 184060)


--- trunk/Tools/ChangeLog	2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/Tools/ChangeLog	2015-05-11 00:57:01 UTC (rev 184060)
@@ -1,3 +1,14 @@
+2015-05-10  Martin Robinson  <[email protected]>
+
+        [GTK] fast/events/page-visibility-transition-test.html is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=114789
+
+        Reviewed by Darin Adler.
+
+        * WebKitTestRunner/gtk/TestControllerGtk.cpp:
+        (WTR::TestController::setHidden): Map and unmap the WebView when the harness
+        requests visibility changes.
+
 2015-05-10  Csaba Osztrogonác  <[email protected]>
 
         [EFL] Fix install-dependencies on Ubuntu 14.10/15.04

Modified: trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp (184059 => 184060)


--- trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2015-05-10 23:28:55 UTC (rev 184059)
+++ trunk/Tools/WebKitTestRunner/gtk/TestControllerGtk.cpp	2015-05-11 00:57:01 UTC (rev 184060)
@@ -95,9 +95,14 @@
 {
 }
 
-void TestController::setHidden(bool)
+void TestController::setHidden(bool hidden)
 {
-    // FIXME: Need to implement this to test visibilityState.
+    if (!m_mainWebView)
+        return;
+    if (hidden)
+        gtk_widget_unmap(GTK_WIDGET(m_mainWebView->platformView()));
+    else
+        gtk_widget_map(GTK_WIDGET(m_mainWebView->platformView()));
 }
 
 void TestController::runModal(PlatformWebView*)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to