Title: [184067] trunk/Source/WebCore
- Revision
- 184067
- Author
- [email protected]
- Date
- 2015-05-10 23:38:50 -0700 (Sun, 10 May 2015)
Log Message
Have MediaStream::getAudioTracks(), MediaStream::getVideoTracks() return const references
https://bugs.webkit.org/show_bug.cgi?id=144794
Reviewed by Philippe Normand.
* Modules/mediastream/MediaStream.h: getAudioTracks() and getVideoTracks()
should return a const reference to the member variables, instead of
copying the objects on every call.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184066 => 184067)
--- trunk/Source/WebCore/ChangeLog 2015-05-11 05:53:20 UTC (rev 184066)
+++ trunk/Source/WebCore/ChangeLog 2015-05-11 06:38:50 UTC (rev 184067)
@@ -1,3 +1,14 @@
+2015-05-10 Zan Dobersek <[email protected]>
+
+ Have MediaStream::getAudioTracks(), MediaStream::getVideoTracks() return const references
+ https://bugs.webkit.org/show_bug.cgi?id=144794
+
+ Reviewed by Philippe Normand.
+
+ * Modules/mediastream/MediaStream.h: getAudioTracks() and getVideoTracks()
+ should return a const reference to the member variables, instead of
+ copying the objects on every call.
+
2015-05-10 Gyuyoung Kim <[email protected]>
Use Ref instead of PassRefPtr in WebCore/page
Modified: trunk/Source/WebCore/Modules/mediastream/MediaStream.h (184066 => 184067)
--- trunk/Source/WebCore/Modules/mediastream/MediaStream.h 2015-05-11 05:53:20 UTC (rev 184066)
+++ trunk/Source/WebCore/Modules/mediastream/MediaStream.h 2015-05-11 06:38:50 UTC (rev 184067)
@@ -63,8 +63,8 @@
void removeTrack(PassRefPtr<MediaStreamTrack>, ExceptionCode&);
MediaStreamTrack* getTrackById(String);
- Vector<RefPtr<MediaStreamTrack>> getAudioTracks() const { return m_audioTracks; }
- Vector<RefPtr<MediaStreamTrack>> getVideoTracks() const { return m_videoTracks; }
+ const Vector<RefPtr<MediaStreamTrack>>& getAudioTracks() const { return m_audioTracks; }
+ const Vector<RefPtr<MediaStreamTrack>>& getVideoTracks() const { return m_videoTracks; }
Vector<RefPtr<MediaStreamTrack>> getTracks();
PassRefPtr<MediaStream> clone();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
