Title: [184127] trunk/Source/_javascript_Core
- Revision
- 184127
- Author
- [email protected]
- Date
- 2015-05-11 15:41:36 -0700 (Mon, 11 May 2015)
Log Message
gmail and google maps fail to load with eager compilation: Failed to insert inline cache for varargs call (specifically, CallForwardVarargs) because we thought the size would be 250 but it ended up being 262 prior to compaction.
https://bugs.webkit.org/show_bug.cgi?id=144854
Reviewed by Oliver Hunt.
This is easy: just lift the threshold. Also remove the need for some duplicate thresholds.
It used to be that Construct required less code, but that's not the case for now.
* ftl/FTLInlineCacheSize.cpp:
(JSC::FTL::sizeOfCallForwardVarargs):
(JSC::FTL::sizeOfConstructVarargs):
(JSC::FTL::sizeOfConstructForwardVarargs):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (184126 => 184127)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-11 22:36:51 UTC (rev 184126)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-11 22:41:36 UTC (rev 184127)
@@ -1,3 +1,18 @@
+2015-05-11 Filip Pizlo <[email protected]>
+
+ gmail and google maps fail to load with eager compilation: Failed to insert inline cache for varargs call (specifically, CallForwardVarargs) because we thought the size would be 250 but it ended up being 262 prior to compaction.
+ https://bugs.webkit.org/show_bug.cgi?id=144854
+
+ Reviewed by Oliver Hunt.
+
+ This is easy: just lift the threshold. Also remove the need for some duplicate thresholds.
+ It used to be that Construct required less code, but that's not the case for now.
+
+ * ftl/FTLInlineCacheSize.cpp:
+ (JSC::FTL::sizeOfCallForwardVarargs):
+ (JSC::FTL::sizeOfConstructVarargs):
+ (JSC::FTL::sizeOfConstructForwardVarargs):
+
2015-05-11 Ryosuke Niwa <[email protected]>
REGRESSION(r180595): same-callee profiling no longer works
Modified: trunk/Source/_javascript_Core/ftl/FTLInlineCacheSize.cpp (184126 => 184127)
--- trunk/Source/_javascript_Core/ftl/FTLInlineCacheSize.cpp 2015-05-11 22:36:51 UTC (rev 184126)
+++ trunk/Source/_javascript_Core/ftl/FTLInlineCacheSize.cpp 2015-05-11 22:41:36 UTC (rev 184127)
@@ -87,26 +87,18 @@
#if CPU(ARM64)
return 312;
#else
- return 250;
+ return 262;
#endif
}
size_t sizeOfConstructVarargs()
{
-#if CPU(ARM64)
- return 332;
-#else
- return 275;
-#endif
+ return sizeOfCallVarargs(); // Should be the same size.
}
size_t sizeOfConstructForwardVarargs()
{
-#if CPU(ARM64)
- return 312;
-#else
- return 250;
-#endif
+ return sizeOfCallForwardVarargs(); // Should be the same size.
}
size_t sizeOfIn()
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
