Title: [184178] releases/WebKitGTK/webkit-2.8/Source/WebCore
Revision
184178
Author
[email protected]
Date
2015-05-12 01:48:04 -0700 (Tue, 12 May 2015)

Log Message

Merge r183887 - RenderLayer::currentTransform computes a pixel snapped rect it doesn't use.
https://bugs.webkit.org/show_bug.cgi?id=144708

Reviewed by Simon Fraser.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::currentTransform):

Only compute a pixel snapped rect if we actually end up needing it. The common case
is that this rect is not needed, so pushing it inside the two if statements
speeds up the common case.

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog (184177 => 184178)


--- releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-05-12 08:47:14 UTC (rev 184177)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/ChangeLog	2015-05-12 08:48:04 UTC (rev 184178)
@@ -1,5 +1,19 @@
 2015-05-06  David Hyatt  <[email protected]>
 
+        RenderLayer::currentTransform computes a pixel snapped rect it doesn't use.
+        https://bugs.webkit.org/show_bug.cgi?id=144708
+
+        Reviewed by Simon Fraser.
+
+        * rendering/RenderLayer.cpp:
+        (WebCore::RenderLayer::currentTransform):
+
+        Only compute a pixel snapped rect if we actually end up needing it. The common case
+        is that this rect is not needed, so pushing it inside the two if statements
+        speeds up the common case.
+
+2015-05-06  David Hyatt  <[email protected]>
+
         Optimize topLeftLocationOffset() addition in updateLayerPosition
         https://bugs.webkit.org/show_bug.cgi?id=144704
 

Modified: releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderLayer.cpp (184177 => 184178)


--- releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderLayer.cpp	2015-05-12 08:47:14 UTC (rev 184177)
+++ releases/WebKitGTK/webkit-2.8/Source/WebCore/rendering/RenderLayer.cpp	2015-05-12 08:48:04 UTC (rev 184178)
@@ -971,12 +971,12 @@
 {
     if (!m_transform)
         return TransformationMatrix();
-
+    
     RenderBox* box = renderBox();
     ASSERT(box);
-    FloatRect pixelSnappedBorderRect = snapRectToDevicePixels(box->borderBoxRect(), box->document().deviceScaleFactor());
     if (renderer().style().isRunningAcceleratedAnimation()) {
         TransformationMatrix currTransform;
+        FloatRect pixelSnappedBorderRect = snapRectToDevicePixels(box->borderBoxRect(), box->document().deviceScaleFactor());
         RefPtr<RenderStyle> style = renderer().animation().getAnimatedStyleForRenderer(renderer());
         style->applyTransform(currTransform, pixelSnappedBorderRect, applyOrigin);
         makeMatrixRenderable(currTransform, canRender3DTransforms());
@@ -986,6 +986,7 @@
     // m_transform includes transform-origin, so we need to recompute the transform here.
     if (applyOrigin == RenderStyle::ExcludeTransformOrigin) {
         TransformationMatrix currTransform;
+        FloatRect pixelSnappedBorderRect = snapRectToDevicePixels(box->borderBoxRect(), box->document().deviceScaleFactor());
         box->style().applyTransform(currTransform, pixelSnappedBorderRect, RenderStyle::ExcludeTransformOrigin);
         makeMatrixRenderable(currTransform, canRender3DTransforms());
         return currTransform;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to