Title: [184224] trunk/Source/WebCore
Revision
184224
Author
[email protected]
Date
2015-05-12 16:13:01 -0700 (Tue, 12 May 2015)

Log Message

Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty
https://bugs.webkit.org/show_bug.cgi?id=144882

Reviewed by Brian Burg.

A timeline recording will always be stopped before the end of the current run loop is observed. Before
dispatching the recording stopped event, the last run loop record must be completed and sent to the frontend
to prevent it from being discarded.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStop):

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (184223 => 184224)


--- trunk/Source/WebCore/ChangeLog	2015-05-12 22:06:44 UTC (rev 184223)
+++ trunk/Source/WebCore/ChangeLog	2015-05-12 23:13:01 UTC (rev 184224)
@@ -1,3 +1,17 @@
+2015-05-12  Matt Baker  <[email protected]>
+
+        Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty
+        https://bugs.webkit.org/show_bug.cgi?id=144882
+
+        Reviewed by Brian Burg.
+
+        A timeline recording will always be stopped before the end of the current run loop is observed. Before
+        dispatching the recording stopped event, the last run loop record must be completed and sent to the frontend
+        to prevent it from being discarded.
+
+        * inspector/InspectorTimelineAgent.cpp:
+        (WebCore::InspectorTimelineAgent::internalStop):
+
 2015-05-12  Zalan Bujtas  <[email protected]>
 
         REGRESSION(r175617): Some text doesn't render on internationalculinarycenter.com

Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (184223 => 184224)


--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2015-05-12 22:06:44 UTC (rev 184223)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp	2015-05-12 23:13:01 UTC (rev 184224)
@@ -198,6 +198,10 @@
 #if PLATFORM(COCOA)
     m_frameStartObserver = nullptr;
     m_frameStopObserver = nullptr;
+    if (m_didStartRecordingRunLoop) {
+        m_didStartRecordingRunLoop = false;
+        didCompleteCurrentRecord(TimelineRecordType::RenderingFrame);
+    }
 #endif
 
     clearRecordStack();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to