Title: [184241] trunk/Source/WebKit2
Revision
184241
Author
[email protected]
Date
2015-05-12 20:51:19 -0700 (Tue, 12 May 2015)

Log Message

Crash when using <input type=file>

<https://bugs.webkit.org/show_bug.cgi?id=144939>
<rdar://problem/20172315>

Reviewed by Andy Estes.

* UIProcess/ios/forms/WKFileUploadPanel.mm:
Use a RefPtr to hold the WebOpenPanelResultListenerProxy, because the
WKFileUploadPanel can outlive it.

Modified Paths

Diff

Modified: trunk/Source/WebKit2/ChangeLog (184240 => 184241)


--- trunk/Source/WebKit2/ChangeLog	2015-05-13 03:45:26 UTC (rev 184240)
+++ trunk/Source/WebKit2/ChangeLog	2015-05-13 03:51:19 UTC (rev 184241)
@@ -1,3 +1,16 @@
+2015-05-12  Jon Honeycutt  <[email protected]>
+
+        Crash when using <input type=file>
+
+        <https://bugs.webkit.org/show_bug.cgi?id=144939>
+        <rdar://problem/20172315>
+
+        Reviewed by Andy Estes.
+
+        * UIProcess/ios/forms/WKFileUploadPanel.mm:
+        Use a RefPtr to hold the WebOpenPanelResultListenerProxy, because the
+        WKFileUploadPanel can outlive it.
+
 2015-05-12  Simon Fraser  <[email protected]>
 
         Turn antialiased font dilation off by default

Modified: trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm (184240 => 184241)


--- trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm	2015-05-13 03:45:26 UTC (rev 184240)
+++ trunk/Source/WebKit2/UIProcess/ios/forms/WKFileUploadPanel.mm	2015-05-13 03:51:19 UTC (rev 184241)
@@ -283,7 +283,7 @@
 
 @implementation WKFileUploadPanel {
     WKContentView *_view;
-    WebKit::WebOpenPanelResultListenerProxy* _listener;
+    RefPtr<WebKit::WebOpenPanelResultListenerProxy> _listener;
     RetainPtr<NSArray> _mimeTypes;
     CGPoint _interactionPoint;
     BOOL _allowMultipleFiles;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to