Title: [184294] trunk/Source/WebKit2
- Revision
- 184294
- Author
- [email protected]
- Date
- 2015-05-13 12:20:42 -0700 (Wed, 13 May 2015)
Log Message
Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page
https://bugs.webkit.org/show_bug.cgi?id=144957
Patch by Joseph Pecoraro <[email protected]> on 2015-05-13
Reviewed by Simon Fraser.
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attachAvailabilityChanged):
Modified Paths
Diff
Modified: trunk/Source/WebKit2/ChangeLog (184293 => 184294)
--- trunk/Source/WebKit2/ChangeLog 2015-05-13 18:56:15 UTC (rev 184293)
+++ trunk/Source/WebKit2/ChangeLog 2015-05-13 19:20:42 UTC (rev 184294)
@@ -1,5 +1,15 @@
2015-05-13 Joseph Pecoraro <[email protected]>
+ Crash under WebKit::WebInspectorProxy::attachAvailabilityChanged sometimes opening new page
+ https://bugs.webkit.org/show_bug.cgi?id=144957
+
+ Reviewed by Simon Fraser.
+
+ * UIProcess/WebInspectorProxy.cpp:
+ (WebKit::WebInspectorProxy::attachAvailabilityChanged):
+
+2015-05-13 Joseph Pecoraro <[email protected]>
+
Pass String as reference in more places
https://bugs.webkit.org/show_bug.cgi?id=144769
Modified: trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp (184293 => 184294)
--- trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-05-13 18:56:15 UTC (rev 184293)
+++ trunk/Source/WebKit2/UIProcess/WebInspectorProxy.cpp 2015-05-13 19:20:42 UTC (rev 184294)
@@ -574,7 +574,7 @@
if (previousCanAttach == m_canAttach)
return;
- if (!m_underTest)
+ if (m_inspectorPage && !m_underTest)
m_inspectorPage->process().send(Messages::WebInspectorUI::SetDockingUnavailable(!m_canAttach), m_inspectorPage->pageID());
platformAttachAvailabilityChanged(m_canAttach);
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes