Title: [184396] trunk/Source/WebCore
- Revision
- 184396
- Author
- [email protected]
- Date
- 2015-05-15 10:58:26 -0700 (Fri, 15 May 2015)
Log Message
Checkmark on OFF option of captions sometimes does not appear.
https://bugs.webkit.org/show_bug.cgi?id=145060.
<rdar://problem/19388333>
Reviewed by Eric Carlson.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.buildCaptionMenu):
Audio tracks don’t have an OFF option.
Remove related code to allow OFF option for subtitles to work properly.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184395 => 184396)
--- trunk/Source/WebCore/ChangeLog 2015-05-15 17:39:05 UTC (rev 184395)
+++ trunk/Source/WebCore/ChangeLog 2015-05-15 17:58:26 UTC (rev 184396)
@@ -1,3 +1,16 @@
+2015-05-15 Roger Fong <[email protected]>
+
+ Checkmark on OFF option of captions sometimes does not appear.
+ https://bugs.webkit.org/show_bug.cgi?id=145060.
+ <rdar://problem/19388333>
+
+ Reviewed by Eric Carlson.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.buildCaptionMenu):
+ Audio tracks don’t have an OFF option.
+ Remove related code to allow OFF option for subtitles to work properly.
+
2015-05-15 Zalan Bujtas <[email protected]>
White edge on animating panel on http://rokkosunnyvale.com
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (184395 => 184396)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-15 17:39:05 UTC (rev 184395)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-15 17:58:26 UTC (rev 184396)
@@ -1537,18 +1537,11 @@
menuItem.track = track;
if (track.enabled) {
- var trackMenuItemSelected = true;
menuItem.classList.add(this.ClassNames.selected);
menuItem.setAttribute('tabindex', '0');
menuItem.setAttribute('aria-checked', 'true');
}
}
-
- if (offMenu && displayMode === 'forced-only' && !trackMenuItemSelected) {
- offMenu.classList.add(this.ClassNames.selected);
- menuItem.setAttribute('tabindex', '0');
- menuItem.setAttribute('aria-checked', 'true');
- }
}
if (textTracks && textTracks.length > 2) {
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
