Title: [184428] trunk/Source/WebCore
- Revision
- 184428
- Author
- [email protected]
- Date
- 2015-05-15 20:46:25 -0700 (Fri, 15 May 2015)
Log Message
Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty
https://bugs.webkit.org/show_bug.cgi?id=144882
Reviewed by Joseph Pecoraro.
A timeline recording will always be stopped before the end of the current run loop is observed. Before
dispatching the recording stopped event, any events that are currently in progress should be considered
complete and sent to the frontend.
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::internalStop):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184427 => 184428)
--- trunk/Source/WebCore/ChangeLog 2015-05-16 03:00:05 UTC (rev 184427)
+++ trunk/Source/WebCore/ChangeLog 2015-05-16 03:46:25 UTC (rev 184428)
@@ -1,3 +1,17 @@
+2015-05-15 Matt Baker <[email protected]>
+
+ Web Inspector: REGRESSION (r181625): Timeline recording started from console.profile is always empty
+ https://bugs.webkit.org/show_bug.cgi?id=144882
+
+ Reviewed by Joseph Pecoraro.
+
+ A timeline recording will always be stopped before the end of the current run loop is observed. Before
+ dispatching the recording stopped event, any events that are currently in progress should be considered
+ complete and sent to the frontend.
+
+ * inspector/InspectorTimelineAgent.cpp:
+ (WebCore::InspectorTimelineAgent::internalStop):
+
2015-05-15 Commit Queue <[email protected]>
Unreviewed, rolling out r184421.
Modified: trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp (184427 => 184428)
--- trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-05-16 03:00:05 UTC (rev 184427)
+++ trunk/Source/WebCore/inspector/InspectorTimelineAgent.cpp 2015-05-16 03:46:25 UTC (rev 184428)
@@ -198,6 +198,13 @@
#if PLATFORM(COCOA)
m_frameStartObserver = nullptr;
m_frameStopObserver = nullptr;
+ if (m_didStartRecordingRunLoop) {
+ m_didStartRecordingRunLoop = false;
+
+ // Complete all pending records to prevent discarding events that are currently in progress.
+ while (!m_recordStack.isEmpty())
+ didCompleteCurrentRecord(m_recordStack.last().type);
+ }
#endif
clearRecordStack();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
