Title: [184489] releases/WebKitGTK/webkit-2.4/Source
Revision
184489
Author
[email protected]
Date
2015-05-18 09:17:06 -0700 (Mon, 18 May 2015)

Log Message

[GTK] Replace M_SQRT2 with sqrtOfTwoDouble
https://bugs.webkit.org/show_bug.cgi?id=143906

Patch by Milan Crha <[email protected]> on 2015-04-17
Reviewed by Carlos Garcia Campos.

Source/WebCore:

* rendering/mathml/RenderMathMLMenclose.cpp:
(WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
(WebCore::RenderMathMLMenclose::updateLogicalHeight):

Source/WTF:

* wtf/MathExtras.h:

Modified Paths

Diff

Modified: releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog (184488 => 184489)


--- releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog	2015-05-18 14:24:41 UTC (rev 184488)
+++ releases/WebKitGTK/webkit-2.4/Source/WTF/ChangeLog	2015-05-18 16:17:06 UTC (rev 184489)
@@ -1,3 +1,12 @@
+2015-04-17  Milan Crha  <[email protected]>
+
+        [GTK] Replace M_SQRT2 with sqrtOfTwoDouble
+        https://bugs.webkit.org/show_bug.cgi?id=143906
+
+        Reviewed by Carlos Garcia Campos.
+
+        * wtf/MathExtras.h:
+
 2015-04-15  Руслан Ижбулатов  <[email protected]>
 
         Harmonize binary semaphore ifdefs

Modified: releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/MathExtras.h (184488 => 184489)


--- releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/MathExtras.h	2015-05-18 14:24:41 UTC (rev 184488)
+++ releases/WebKitGTK/webkit-2.4/Source/WTF/wtf/MathExtras.h	2015-05-18 16:17:06 UTC (rev 184489)
@@ -67,6 +67,12 @@
 const float piOverFourFloat = static_cast<float>(M_PI_4);
 #endif
 
+#ifndef M_SQRT2
+const double sqrtOfTwoDouble = 1.41421356237309504880;
+#else
+const double sqrtOfTwoDouble = M_SQRT2;
+#endif
+
 #if OS(DARWIN)
 
 // Work around a bug in the Mac OS X libc where ceil(-0.1) return +0.

Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog (184488 => 184489)


--- releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog	2015-05-18 14:24:41 UTC (rev 184488)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/ChangeLog	2015-05-18 16:17:06 UTC (rev 184489)
@@ -1,5 +1,16 @@
 2015-04-17  Milan Crha  <[email protected]>
 
+        [GTK] Replace M_SQRT2 with sqrtOfTwoDouble
+        https://bugs.webkit.org/show_bug.cgi?id=143906
+
+        Reviewed by Carlos Garcia Campos.
+
+        * rendering/mathml/RenderMathMLMenclose.cpp:
+        (WebCore::RenderMathMLMenclose::computePreferredLogicalWidths):
+        (WebCore::RenderMathMLMenclose::updateLogicalHeight):
+
+2015-04-17  Milan Crha  <[email protected]>
+
         [GTK] Make preprocessor.pm / make_names.pl work under msys/mingw
         https://bugs.webkit.org/show_bug.cgi?id=143908
 

Modified: releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp (184488 => 184489)


--- releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp	2015-05-18 14:24:41 UTC (rev 184488)
+++ releases/WebKitGTK/webkit-2.4/Source/WebCore/rendering/mathml/RenderMathMLMenclose.cpp	2015-05-18 16:17:06 UTC (rev 184489)
@@ -71,8 +71,8 @@
     size_t notationalValueSize = notationValues.size();
     for (size_t i = 0; i < notationalValueSize; i++) {
         if (notationValues[i] == "circle") {
-            m_minPreferredLogicalWidth = minPreferredLogicalWidth() * float(M_SQRT2);
-            m_maxPreferredLogicalWidth = maxPreferredLogicalWidth() * float(M_SQRT2);
+            m_minPreferredLogicalWidth = minPreferredLogicalWidth() * float(sqrtOfTwoDouble);
+            m_maxPreferredLogicalWidth = maxPreferredLogicalWidth() * float(sqrtOfTwoDouble);
         }
     }
 
@@ -86,7 +86,7 @@
     size_t notationalValueSize = notationValues.size();
     for (size_t i = 0; i < notationalValueSize; i++)
         if (notationValues[i] == "circle")
-            setLogicalHeight(logicalHeight() * float(M_SQRT2));
+            setLogicalHeight(logicalHeight() * float(sqrtOfTwoDouble));
 }
 
 void RenderMathMLMenclose::paint(PaintInfo& info, const LayoutPoint& paintOffset)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to