Title: [184584] trunk/Source/WebCore
- Revision
- 184584
- Author
- [email protected]
- Date
- 2015-05-19 12:59:48 -0700 (Tue, 19 May 2015)
Log Message
Remove use of deprecated AVKit SPI cancelOptimizedFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=145159
Patch by Jeremy Jones <[email protected]> on 2015-05-19
Reviewed by Eric Carlson.
Remove cancelOptimizedFullscreen, and use stopOptimizedFullscreen instead.
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal):
* platform/spi/cocoa/AVKitSPI.h: remove declaration.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184583 => 184584)
--- trunk/Source/WebCore/ChangeLog 2015-05-19 19:56:52 UTC (rev 184583)
+++ trunk/Source/WebCore/ChangeLog 2015-05-19 19:59:48 UTC (rev 184584)
@@ -1,3 +1,16 @@
+2015-05-19 Jeremy Jones <[email protected]>
+
+ Remove use of deprecated AVKit SPI cancelOptimizedFullscreen.
+ https://bugs.webkit.org/show_bug.cgi?id=145159
+
+ Reviewed by Eric Carlson.
+
+ Remove cancelOptimizedFullscreen, and use stopOptimizedFullscreen instead.
+
+ * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+ (WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal):
+ * platform/spi/cocoa/AVKitSPI.h: remove declaration.
+
2015-05-19 Zalan Bujtas <[email protected]>
Merged anonymous blocks should invalidate simple line layout path.
Modified: trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm (184583 => 184584)
--- trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-05-19 19:56:52 UTC (rev 184583)
+++ trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm 2015-05-19 19:59:48 UTC (rev 184584)
@@ -1129,8 +1129,6 @@
});
}
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wdeprecated-declarations"
void WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal()
{
LOG(Fullscreen, "WebVideoFullscreenInterfaceAVKit::cleanupFullscreenInternal(%p)", this);
@@ -1148,7 +1146,7 @@
[m_playerViewController setPlayerController:nil];
if (hasMode(HTMLMediaElement::VideoFullscreenModeOptimized))
- [m_playerViewController cancelOptimizedFullscreen];
+ [m_playerViewController stopOptimizedFullscreen];
if (hasMode(HTMLMediaElement::VideoFullscreenModeStandard))
[m_playerViewController exitFullScreenAnimated:NO completionHandler:[] (BOOL, NSError *) { }];
@@ -1180,7 +1178,6 @@
strongThis->m_enterRequested = false;
});
}
-#pragma clang diagnostic pop
void WebVideoFullscreenInterfaceAVKit::invalidate()
{
Modified: trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h (184583 => 184584)
--- trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h 2015-05-19 19:56:52 UTC (rev 184583)
+++ trunk/Source/WebCore/platform/spi/cocoa/AVKitSPI.h 2015-05-19 19:59:48 UTC (rev 184584)
@@ -91,7 +91,6 @@
- (void)startOptimizedFullscreen;
- (void)startOptimizedFullscreenWithStartCompletionHandler:(void (^)(BOOL success, NSError*))startCompletionHandler stopCompletionHandler:(void (^)(AVPlayerViewControllerOptimizedFullscreenStopReason))stopCompletionHandler;
- (void)stopOptimizedFullscreen;
-- (void)cancelOptimizedFullscreen;
- (void)setAllowsOptimizedFullscreen:(BOOL)allowsOptimizedFullscreen;
@property (nonatomic, strong) AVPlayerController *playerController;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
