Title: [184601] trunk/Source/WebCore
- Revision
- 184601
- Author
- [email protected]
- Date
- 2015-05-19 16:59:27 -0700 (Tue, 19 May 2015)
Log Message
Upper half of volume control should be filled, not hollow.
https://bugs.webkit.org/show_bug.cgi?id=145187.
<rdar://problem/21021970>
Reviewed by Dean Jackson.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.drawVolumeBackground):
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184600 => 184601)
--- trunk/Source/WebCore/ChangeLog 2015-05-19 23:09:43 UTC (rev 184600)
+++ trunk/Source/WebCore/ChangeLog 2015-05-19 23:59:27 UTC (rev 184601)
@@ -1,3 +1,14 @@
+2015-05-19 Roger Fong <[email protected]>
+
+ Upper half of volume control should be filled, not hollow.
+ https://bugs.webkit.org/show_bug.cgi?id=145187.
+ <rdar://problem/21021970>
+
+ Reviewed by Dean Jackson.
+
+ * Modules/mediacontrols/mediaControlsApple.js:
+ (Controller.prototype.drawVolumeBackground):
+
2015-05-19 Michael Saboff <[email protected]>
REGRESSION(183787): JIT is enabled for all builds
Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (184600 => 184601)
--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-19 23:09:43 UTC (rev 184600)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js 2015-05-19 23:59:27 UTC (rev 184601)
@@ -1268,13 +1268,12 @@
ctx.fillRect(0, 0, width, height);
ctx.restore();
- // Draw volume track border.
+ // Draw portion of volume above slider thumb.
ctx.save();
ctx.beginPath();
this.addRoundedRect(ctx, scrubberPosition, 3, width - scrubberPosition, timelineHeight, timelineHeight / 2.0);
- this.addRoundedRect(ctx, scrubberPosition + 1, 4, width - borderSize - scrubberPosition - 1, trackHeight, trackHeight / 2.0);
ctx.closePath();
- ctx.clip("evenodd");
+ ctx.clip();
ctx.fillStyle = "rgb(30, 30, 30)";
ctx.fillRect(0, 0, width, height);
ctx.restore();
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
