[webkit-changes] [184618] trunk/Source/JavaScriptCore

[commit-queue]

Title: [184618] trunk/Source/_javascript_Core

Revision

184618

Author

commit-qu...@webkit.org

Date

2015-05-19 23:14:03 -0700 (Tue, 19 May 2015)

Log Message

Unreviewed, rolling out r184613 and r184614.
https://bugs.webkit.org/show_bug.cgi?id=145206

Broke 10 tests :| (Requested by kling on #webkit).

Reverted changesets:

"[JSC] Speed up URL encode/decode by using bitmaps instead of
strchr()."
https://bugs.webkit.org/show_bug.cgi?id=145115
http://trac.webkit.org/changeset/184613

"[JSC] Speed up URL encode/decode by using bitmaps instead of
strchr()."
https://bugs.webkit.org/show_bug.cgi?id=145115
http://trac.webkit.org/changeset/184614

Modified Paths

• trunk/Source/_javascript_Core/ChangeLog
• trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp

Diff

Modified: trunk/Source/_javascript_Core/ChangeLog (184617 => 184618)

--- trunk/Source/_javascript_Core/ChangeLog	2015-05-20 05:57:55 UTC (rev 184617)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-05-20 06:14:03 UTC (rev 184618)
@@ -1,3 +1,22 @@
+2015-05-19  Commit Queue  <commit-qu...@webkit.org>
+
+        Unreviewed, rolling out r184613 and r184614.
+        https://bugs.webkit.org/show_bug.cgi?id=145206
+
+        Broke 10 tests :| (Requested by kling on #webkit).
+
+        Reverted changesets:
+
+        "[JSC] Speed up URL encode/decode by using bitmaps instead of
+        strchr()."
+        https://bugs.webkit.org/show_bug.cgi?id=145115
+        http://trac.webkit.org/changeset/184613
+
+        "[JSC] Speed up URL encode/decode by using bitmaps instead of
+        strchr()."
+        https://bugs.webkit.org/show_bug.cgi?id=145115
+        http://trac.webkit.org/changeset/184614
+
 2015-05-19  Andreas Kling  <akl...@apple.com>
 
         Give StringView a utf8() API.

Modified: trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp (184617 => 184618)

--- trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp	2015-05-20 05:57:55 UTC (rev 184617)
+++ trunk/Source/_javascript_Core/runtime/JSGlobalObjectFunctions.cpp	2015-05-20 06:14:03 UTC (rev 184618)
@@ -72,7 +72,7 @@
     const char* p = cstr.data();
     for (size_t k = 0; k < cstr.length(); k++, p++) {
         char c = *p;
-        if (doNotEscape.get(static_cast<LChar>(c)))
+        if (c && doNotEscape.get(static_cast<LChar>(c)))
             builder.append(static_cast<LChar>(c));
         else {
             builder.append(static_cast<LChar>('%'));
@@ -136,7 +136,7 @@
                     u = Lexer<UChar>::convertUnicode(p[2], p[3], p[4], p[5]);
                 }
             }
-            if (charLen && (u >= 128 || !doNotUnescape.get(static_cast<LChar>(u)))) {
+            if (charLen && (u == 0 || u >= 128 || !doNotUnescape.get(static_cast<LChar>(u)))) {
                 builder.append(u);
                 k += charLen;
                 continue;
@@ -687,7 +687,7 @@
         const LChar* c = str.characters8();
         for (unsigned k = 0; k < str.length(); k++, c++) {
             int u = c[0];
-            if (doNotEscape.get(static_cast<LChar>(u)))
+            if (u && doNotEscape.get(static_cast<LChar>(u)))
                 builder.append(*c);
             else {
                 builder.append(static_cast<LChar>('%'));
@@ -706,7 +706,7 @@
             builder.append(static_cast<LChar>('u'));
             appendByteAsHex(u >> 8, builder);
             appendByteAsHex(u & 0xFF, builder);
-        } else if (doNotEscape.get(static_cast<LChar>(u)))
+        } else if (u != 0 && doNotEscape.get(static_cast<LChar>(u)))
             builder.append(*c);
         else {
             builder.append(static_cast<LChar>('%'));

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes