Title: [184623] trunk/Source/WebCore
Revision
184623
Author
[email protected]
Date
2015-05-20 00:55:28 -0700 (Wed, 20 May 2015)

Log Message

REGRESSION(r184420): [GTK] webkit_dom_html_element_get_children has been removed
https://bugs.webkit.org/show_bug.cgi?id=145174

Reviewed by Philippe Normand.

children property has been moved to Element, Document and
DocumentFragment to match the spec, so we need to expose the new
get_children and bring back webkit_dom_html_element_get_children()
as deprecated.

* bindings/gobject/WebKitDOMDeprecated.cpp:
(webkit_dom_html_element_get_children):
* bindings/gobject/WebKitDOMDeprecated.h:
* bindings/gobject/WebKitDOMDeprecated.symbols:
* bindings/gobject/webkitdom.symbols:

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (184622 => 184623)


--- trunk/Source/WebCore/ChangeLog	2015-05-20 07:39:12 UTC (rev 184622)
+++ trunk/Source/WebCore/ChangeLog	2015-05-20 07:55:28 UTC (rev 184623)
@@ -1,3 +1,21 @@
+2015-05-20  Carlos Garcia Campos  <[email protected]>
+
+        REGRESSION(r184420): [GTK] webkit_dom_html_element_get_children has been removed
+        https://bugs.webkit.org/show_bug.cgi?id=145174
+
+        Reviewed by Philippe Normand.
+
+        children property has been moved to Element, Document and
+        DocumentFragment to match the spec, so we need to expose the new
+        get_children and bring back webkit_dom_html_element_get_children()
+        as deprecated.
+
+        * bindings/gobject/WebKitDOMDeprecated.cpp:
+        (webkit_dom_html_element_get_children):
+        * bindings/gobject/WebKitDOMDeprecated.h:
+        * bindings/gobject/WebKitDOMDeprecated.symbols:
+        * bindings/gobject/webkitdom.symbols:
+
 2015-05-20  Hunseop Jeong  <[email protected]>
 
         nullptr cleanup in WebCore/xml.

Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp (184622 => 184623)


--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp	2015-05-20 07:39:12 UTC (rev 184622)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.cpp	2015-05-20 07:55:28 UTC (rev 184623)
@@ -44,3 +44,9 @@
     g_return_if_fail(WEBKIT_DOM_IS_HTML_ELEMENT(self));
     webkit_dom_element_set_outer_html(WEBKIT_DOM_ELEMENT(self), contents, error);
 }
+
+WebKitDOMHTMLCollection* webkit_dom_html_element_get_children(WebKitDOMHTMLElement* self)
+{
+    g_return_val_if_fail(WEBKIT_DOM_IS_HTML_ELEMENT(self), nullptr);
+    return webkit_dom_element_get_children(WEBKIT_DOM_ELEMENT(self));
+}

Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h (184622 => 184623)


--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h	2015-05-20 07:39:12 UTC (rev 184622)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.h	2015-05-20 07:55:28 UTC (rev 184623)
@@ -70,6 +70,17 @@
 WEBKIT_DEPRECATED_FOR(webkit_dom_element_set_outer_html) void
 webkit_dom_html_element_set_outer_html(WebKitDOMHTMLElement* self, const gchar* contents, GError** error);
 
+/**
+ * webkit_dom_html_element_get_children:
+ * @self: A #WebKitDOMHTMLElement
+ *
+ * Returns: (transfer full): A #WebKitDOMHTMLCollection
+ *
+ * Deprecated: 2.10: Use webkit_dom_element_get_children() instead.
+ */
+WEBKIT_DEPRECATED_FOR(webkit_dom_element_get_children) WebKitDOMHTMLCollection*
+webkit_dom_html_element_get_children(WebKitDOMHTMLElement* self);
+
 G_END_DECLS
 
 #endif /* WEBKIT_DISABLE_DEPRECATED */

Modified: trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols (184622 => 184623)


--- trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols	2015-05-20 07:39:12 UTC (rev 184622)
+++ trunk/Source/WebCore/bindings/gobject/WebKitDOMDeprecated.symbols	2015-05-20 07:55:28 UTC (rev 184623)
@@ -2,3 +2,4 @@
 gchar* webkit_dom_html_element_get_outer_html(WebKitDOMHTMLElement*)
 gchar* webkit_dom_html_element_get_inner_html(WebKitDOMHTMLElement*)
 void webkit_dom_html_element_set_outer_html(WebKitDOMHTMLElement*, const gchar*, GError**)
+WebKitDOMHTMLCollection* webkit_dom_html_element_get_children(WebKitDOMHTMLElement*)

Modified: trunk/Source/WebCore/bindings/gobject/webkitdom.symbols (184622 => 184623)


--- trunk/Source/WebCore/bindings/gobject/webkitdom.symbols	2015-05-20 07:39:12 UTC (rev 184622)
+++ trunk/Source/WebCore/bindings/gobject/webkitdom.symbols	2015-05-20 07:55:28 UTC (rev 184623)
@@ -132,6 +132,7 @@
 gdouble webkit_dom_element_get_client_left(WebKitDOMElement*)
 gdouble webkit_dom_element_get_client_height(WebKitDOMElement*)
 gdouble webkit_dom_element_get_client_width(WebKitDOMElement*)
+WebKitDOMHTMLCollection* webkit_dom_element_get_children(WebKitDOMElement*)@2.10
 gboolean webkit_dom_element_has_attributes(WebKitDOMElement*)
 gboolean webkit_dom_element_has_attribute(WebKitDOMElement*, const gchar*)
 gboolean webkit_dom_element_has_attribute_ns(WebKitDOMElement*, const gchar*, const gchar*)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to