Diff
Modified: trunk/LayoutTests/ChangeLog (184649 => 184650)
--- trunk/LayoutTests/ChangeLog 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/LayoutTests/ChangeLog 2015-05-20 20:12:39 UTC (rev 184650)
@@ -1,3 +1,16 @@
+2015-05-20 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r184645.
+ https://bugs.webkit.org/show_bug.cgi?id=145220
+
+ Broken build (Requested by jacob_nielsen on #webkit).
+
+ Reverted changeset:
+
+ "AX: AutoFill button is not accessible with VoiceOver"
+ https://bugs.webkit.org/show_bug.cgi?id=145200
+ http://trac.webkit.org/changeset/184645
+
2015-05-20 Daniel Bates <[email protected]>
AX: AutoFill button is not accessible with VoiceOver
Deleted: trunk/LayoutTests/accessibility/input-auto-fill-button-expected.txt (184649 => 184650)
--- trunk/LayoutTests/accessibility/input-auto-fill-button-expected.txt 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/LayoutTests/accessibility/input-auto-fill-button-expected.txt 2015-05-20 20:12:39 UTC (rev 184650)
@@ -1,11 +0,0 @@
-This tests that there exists an accessibility element for the AutoFill button.
-
-On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
-
-
-PASS accessibilityController.accessibleElementById("password").childAtIndex(0).description is "AXDescription: autofill"
-PASS accessibilityController.accessibleElementById("password").childAtIndex(0).role is "AXRole: AXButton"
-PASS successfullyParsed is true
-
-TEST COMPLETE
-
Deleted: trunk/LayoutTests/accessibility/input-auto-fill-button.html (184649 => 184650)
--- trunk/LayoutTests/accessibility/input-auto-fill-button.html 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/LayoutTests/accessibility/input-auto-fill-button.html 2015-05-20 20:12:39 UTC (rev 184650)
@@ -1,22 +0,0 @@
-<!DOCTYPE html>
-<html>
-<head>
-<script src=""
-</head>
-<body>
-<input type="password" id="password">
-<script>
-description("This tests that there exists an accessibility element for the AutoFill button.");
-
-if (!window.internals || !window.accessibilityController)
- testFailed("You must run this test in the test tool and have implemented window.internals and window.accessibilityController.");
-else {
- internals.setShowAutoFillButton(document.getElementById("password"), true);
-
- shouldBeEqualToString('accessibilityController.accessibleElementById("password").childAtIndex(0).description', "AXDescription: autofill");
- shouldBeEqualToString('accessibilityController.accessibleElementById("password").childAtIndex(0).role', "AXRole: AXButton");
-}
-</script>
-<script src=""
-</body>
-</html>
Modified: trunk/Source/WebCore/ChangeLog (184649 => 184650)
--- trunk/Source/WebCore/ChangeLog 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/ChangeLog 2015-05-20 20:12:39 UTC (rev 184650)
@@ -1,3 +1,16 @@
+2015-05-20 Commit Queue <[email protected]>
+
+ Unreviewed, rolling out r184645.
+ https://bugs.webkit.org/show_bug.cgi?id=145220
+
+ Broken build (Requested by jacob_nielsen on #webkit).
+
+ Reverted changeset:
+
+ "AX: AutoFill button is not accessible with VoiceOver"
+ https://bugs.webkit.org/show_bug.cgi?id=145200
+ http://trac.webkit.org/changeset/184645
+
2015-05-20 Daniel Bates <[email protected]>
AX: AutoFill button is not accessible with VoiceOver
Modified: trunk/Source/WebCore/English.lproj/Localizable.strings (184649 => 184650)
--- trunk/Source/WebCore/English.lproj/Localizable.strings 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/English.lproj/Localizable.strings 2015-05-20 20:12:39 UTC (rev 184650)
@@ -760,9 +760,6 @@
/* accessibility description for a search field cancel button */
"cancel" = "cancel";
-/* accessibility description for a password field AutoFill button */
-"autofill" = "autofill";
-
/* Verb stating the action that will occur when an unchecked checkbox is clicked, as used by accessibility */
"check" = "check";
Modified: trunk/Source/WebCore/html/TextFieldInputType.cpp (184649 => 184650)
--- trunk/Source/WebCore/html/TextFieldInputType.cpp 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/html/TextFieldInputType.cpp 2015-05-20 20:12:39 UTC (rev 184650)
@@ -42,7 +42,6 @@
#include "HTMLInputElement.h"
#include "HTMLNames.h"
#include "KeyboardEvent.h"
-#include "LocalizedStrings.h"
#include "NodeRenderStyle.h"
#include "Page.h"
#include "PlatformKeyboardEvent.h"
@@ -603,8 +602,6 @@
m_autoFillButton = AutoFillButtonElement::create(element().document(), *this);
m_autoFillButton->setPseudo(AtomicString("-webkit-auto-fill-button", AtomicString::ConstructFromLiteral));
- m_autoFillButton->setAttribute(aria_labelAttr, AtomicString(AXAutoFillButtonText()));
- m_autoFillButton->setAttribute(roleAttr, AtomicString("button", AtomicString::ConstructFromLiteral));
m_container->appendChild(m_autoFillButton, IGNORE_EXCEPTION);
}
Modified: trunk/Source/WebCore/platform/LocalizedStrings.cpp (184649 => 184650)
--- trunk/Source/WebCore/platform/LocalizedStrings.cpp 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/platform/LocalizedStrings.cpp 2015-05-20 20:12:39 UTC (rev 184650)
@@ -604,11 +604,6 @@
return WEB_UI_STRING("cancel", "accessibility description for a search field cancel button");
}
-String AXAutoFillButtonText()
-{
- return WEB_UI_STRING("autofill", "accessibility description for a password field AutoFill button");
-}
-
String AXButtonActionVerb()
{
return WEB_UI_STRING("press", "Verb stating the action that will occur when a button is pressed, as used by accessibility");
Modified: trunk/Source/WebCore/platform/LocalizedStrings.h (184649 => 184650)
--- trunk/Source/WebCore/platform/LocalizedStrings.h 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/platform/LocalizedStrings.h 2015-05-20 20:12:39 UTC (rev 184650)
@@ -162,7 +162,7 @@
String AXFooterRoleDescriptionText();
String AXFileUploadButtonText();
String AXSearchFieldCancelButtonText();
-
+
String AXButtonActionVerb();
String AXRadioButtonActionVerb();
String AXTextFieldActionVerb();
@@ -174,8 +174,6 @@
String AXListItemActionVerb();
#endif
- String AXAutoFillButtonText();
-
#if ENABLE(INPUT_TYPE_WEEK)
// weekFormatInLDML() returns week and year format in LDML, Unicode
// technical standard 35, Locale Data Markup Language, e.g. "'Week' ww, yyyy"
Modified: trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp (184649 => 184650)
--- trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/platform/efl/LocalizedStringsEfl.cpp 2015-05-20 20:12:39 UTC (rev 184650)
@@ -408,11 +408,6 @@
return String::fromUTF8("cancel");
}
-String AXAutoFillButtonText()
-{
- return String::fromUTF8("autofill");
-}
-
String AXButtonActionVerb()
{
return String::fromUTF8("press");
Modified: trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp (184649 => 184650)
--- trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2015-05-20 20:08:27 UTC (rev 184649)
+++ trunk/Source/WebCore/platform/gtk/LocalizedStringsGtk.cpp 2015-05-20 20:12:39 UTC (rev 184650)
@@ -456,11 +456,6 @@
return String::fromUTF8(_("cancel"));
}
-String AXAutoFillButtonText()
-{
- return String::fromUTF8(_("autofill"));
-}
-
String AXButtonActionVerb()
{
return String::fromUTF8(_("press"));
