Title: [184659] trunk/Source/WebCore
- Revision
- 184659
- Author
- [email protected]
- Date
- 2015-05-20 14:36:20 -0700 (Wed, 20 May 2015)
Log Message
Label text for default buttons don’t have the correct white color
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>
Reviewed by Tim Horton.
Use a 85% solid white for the active text color on buttons.
As has been disappointingly pointed out in other patches, we don't
have a good way to test ActiveButtonText since it only applies at
paint time.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor): Move to an 85% solid white.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184658 => 184659)
--- trunk/Source/WebCore/ChangeLog 2015-05-20 21:22:21 UTC (rev 184658)
+++ trunk/Source/WebCore/ChangeLog 2015-05-20 21:36:20 UTC (rev 184659)
@@ -1,3 +1,20 @@
+2015-05-20 Dean Jackson <[email protected]>
+
+ Label text for default buttons don’t have the correct white color
+ https://bugs.webkit.org/show_bug.cgi?id=145221
+ <rdar://problem/20985817>
+
+ Reviewed by Tim Horton.
+
+ Use a 85% solid white for the active text color on buttons.
+
+ As has been disappointingly pointed out in other patches, we don't
+ have a good way to test ActiveButtonText since it only applies at
+ paint time.
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::systemColor): Move to an 85% solid white.
+
2015-05-20 Alexey Proskuryakov <[email protected]>
ThreadableLoaderOptions::isolatedCopy() doesn't produce a copy that is safe for sending to another thread
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (184658 => 184659)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-05-20 21:22:21 UTC (rev 184658)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-05-20 21:36:20 UTC (rev 184659)
@@ -478,7 +478,7 @@
case CSSValueActivebuttontext:
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
// There is no corresponding NSColor for this so we use a hard coded value.
- color = 0xC0FFFFFF;
+ color = 0xDAFFFFFF;
#else
color = convertNSColorToColor([NSColor controlTextColor]);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
