Title: [184682] trunk/Source/WebCore
Revision
184682
Author
[email protected]
Date
2015-05-20 17:58:25 -0700 (Wed, 20 May 2015)

Log Message

Unreviewed. Media Controls stop updating after hovering for a few seconds.
https://bugs.webkit.org/show_bug.cgi?id=144770.
<rdar://problem/19823121>

Followup to r184667.
* Modules/mediacontrols/mediaControlsApple.js:
(Controller.prototype.showControls):
Only put controls back into the tree if they don’t yet exist in the tree.
Otherwise we interrupt operations like scrubbing.

Modified Paths

Diff

Modified: trunk/Source/WebCore/ChangeLog (184681 => 184682)


--- trunk/Source/WebCore/ChangeLog	2015-05-21 00:52:33 UTC (rev 184681)
+++ trunk/Source/WebCore/ChangeLog	2015-05-21 00:58:25 UTC (rev 184682)
@@ -1,3 +1,15 @@
+2015-05-20  Roger Fong  <[email protected]>
+
+        Unreviewed. Media Controls stop updating after hovering for a few seconds.
+        https://bugs.webkit.org/show_bug.cgi?id=144770.
+        <rdar://problem/19823121>
+
+        Followup to r184667.
+        * Modules/mediacontrols/mediaControlsApple.js:
+        (Controller.prototype.showControls):
+        Only put controls back into the tree if they don’t yet exist in the tree.
+        Otherwise we interrupt operations like scrubbing.
+
 2015-05-20  Enrica Casucci  <[email protected]>
 
         [iOS] Using CSS viewport units causes incorrect layout.

Modified: trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js (184681 => 184682)


--- trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-05-21 00:52:33 UTC (rev 184681)
+++ trunk/Source/WebCore/Modules/mediacontrols/mediaControlsApple.js	2015-05-21 00:58:25 UTC (rev 184682)
@@ -1379,7 +1379,7 @@
             return;
 
         this.updateForShowingControls();
-        if (this.shouldHaveControls()) {
+        if (this.shouldHaveControls() && this.controlsAreHidden()) {
             this.base.appendChild(this.controls.inlinePlaybackPlaceholder);
             this.base.appendChild(this.controls.panel);
         }
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to