Title: [184685] trunk/Source/WebCore
- Revision
- 184685
- Author
- [email protected]
- Date
- 2015-05-20 18:28:31 -0700 (Wed, 20 May 2015)
Log Message
Label text for default buttons don’t have the correct white color
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>
Follow-up commit. After discussion with the AppKit team, we've
concluded that a solid white is the color that best matches
the system.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::systemColor): Use Color::white.
Modified Paths
Diff
Modified: trunk/Source/WebCore/ChangeLog (184684 => 184685)
--- trunk/Source/WebCore/ChangeLog 2015-05-21 01:15:43 UTC (rev 184684)
+++ trunk/Source/WebCore/ChangeLog 2015-05-21 01:28:31 UTC (rev 184685)
@@ -208,6 +208,19 @@
https://bugs.webkit.org/show_bug.cgi?id=145221
<rdar://problem/20985817>
+ Follow-up commit. After discussion with the AppKit team, we've
+ concluded that a solid white is the color that best matches
+ the system.
+
+ * rendering/RenderThemeMac.mm:
+ (WebCore::RenderThemeMac::systemColor): Use Color::white.
+
+2015-05-20 Dean Jackson <[email protected]>
+
+ Label text for default buttons don’t have the correct white color
+ https://bugs.webkit.org/show_bug.cgi?id=145221
+ <rdar://problem/20985817>
+
Reviewed by Tim Horton.
Use a 85% solid white for the active text color on buttons.
Modified: trunk/Source/WebCore/rendering/RenderThemeMac.mm (184684 => 184685)
--- trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-05-21 01:15:43 UTC (rev 184684)
+++ trunk/Source/WebCore/rendering/RenderThemeMac.mm 2015-05-21 01:28:31 UTC (rev 184685)
@@ -478,7 +478,7 @@
case CSSValueActivebuttontext:
#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
// There is no corresponding NSColor for this so we use a hard coded value.
- color = 0xDAFFFFFF;
+ color = Color::white;
#else
color = convertNSColorToColor([NSColor controlTextColor]);
#endif
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
