[webkit-changes] [184699] trunk

Wed, 20 May 2015 22:13:25 -0700

Title: [184699] trunk
Revision
184699
Author
[email protected]
Date
2015-05-20 22:13:03 -0700 (Wed, 20 May 2015)

Log Message

Web Inspector: array previews should have a much smaller cap on values
https://bugs.webkit.org/show_bug.cgi?id=145195

Patch by Joseph Pecoraro <[email protected]> on 2015-05-20
Reviewed by Timothy Hatcher.

Source/_javascript_Core:

* inspector/InjectedScriptSource.js:
(InjectedScript.RemoteObject.prototype._generatePreview):
Reduce the indexes threshold for previews.

LayoutTests:

* inspector/model/remote-object-expected.txt:
Update expected results now that array previews include
a smaller number of items.

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (184698 => 184699)


--- trunk/LayoutTests/ChangeLog	2015-05-21 05:12:10 UTC (rev 184698)
+++ trunk/LayoutTests/ChangeLog	2015-05-21 05:13:03 UTC (rev 184699)
@@ -1,3 +1,14 @@
+2015-05-20  Joseph Pecoraro  <[email protected]>
+
+        Web Inspector: array previews should have a much smaller cap on values
+        https://bugs.webkit.org/show_bug.cgi?id=145195
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/model/remote-object-expected.txt:
+        Update expected results now that array previews include
+        a smaller number of items.
+
 2015-05-20  Marcos Chavarría Teijeiro  <[email protected]>
 
         Enable disk cache for range requests

Modified: trunk/LayoutTests/inspector/model/remote-object-expected.txt (184698 => 184699)


--- trunk/LayoutTests/inspector/model/remote-object-expected.txt	2015-05-21 05:12:10 UTC (rev 184698)
+++ trunk/LayoutTests/inspector/model/remote-object-expected.txt	2015-05-21 05:13:03 UTC (rev 184699)
@@ -994,8 +994,8 @@
     "_type": "object",
     "_subtype": "array",
     "_description": "Array",
-    "_lossless": true,
-    "_overflow": false,
+    "_lossless": false,
+    "_overflow": true,
     "_size": 100,
     "_properties": [
       {
@@ -1047,456 +1047,6 @@
         "_name": "9",
         "_type": "number",
         "_value": "1"
-      },
-      {
-        "_name": "10",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "11",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "12",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "13",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "14",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "15",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "16",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "17",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "18",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "19",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "20",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "21",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "22",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "23",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "24",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "25",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "26",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "27",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "28",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "29",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "30",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "31",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "32",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "33",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "34",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "35",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "36",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "37",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "38",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "39",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "40",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "41",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "42",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "43",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "44",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "45",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "46",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "47",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "48",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "49",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "50",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "51",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "52",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "53",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "54",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "55",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "56",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "57",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "58",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "59",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "60",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "61",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "62",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "63",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "64",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "65",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "66",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "67",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "68",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "69",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "70",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "71",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "72",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "73",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "74",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "75",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "76",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "77",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "78",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "79",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "80",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "81",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "82",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "83",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "84",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "85",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "86",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "87",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "88",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "89",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "90",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "91",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "92",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "93",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "94",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "95",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "96",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "97",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "98",
-        "_type": "number",
-        "_value": "1"
-      },
-      {
-        "_name": "99",
-        "_type": "number",
-        "_value": "1"
       }
     ],
     "_entries": null

Modified: trunk/Source/_javascript_Core/ChangeLog (184698 => 184699)


--- trunk/Source/_javascript_Core/ChangeLog	2015-05-21 05:12:10 UTC (rev 184698)
+++ trunk/Source/_javascript_Core/ChangeLog	2015-05-21 05:13:03 UTC (rev 184699)
@@ -1,5 +1,16 @@
 2015-05-20  Joseph Pecoraro  <[email protected]>
 
+        Web Inspector: array previews should have a much smaller cap on values
+        https://bugs.webkit.org/show_bug.cgi?id=145195
+
+        Reviewed by Timothy Hatcher.
+
+        * inspector/InjectedScriptSource.js:
+        (InjectedScript.RemoteObject.prototype._generatePreview):
+        Reduce the indexes threshold for previews.
+
+2015-05-20  Joseph Pecoraro  <[email protected]>
+
         Web Inspector: Use native Arguments detection instead of using toString
         https://bugs.webkit.org/show_bug.cgi?id=145235

Modified: trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js (184698 => 184699)


--- trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js	2015-05-21 05:12:10 UTC (rev 184698)
+++ trunk/Source/_javascript_Core/inspector/InjectedScriptSource.js	2015-05-21 05:13:03 UTC (rev 184699)
@@ -1035,7 +1035,7 @@
 
         var propertiesThreshold = {
             properties: isTableRowsRequest ? 1000 : Math.max(5, firstLevelKeysCount),
-            indexes: isTableRowsRequest ? 1000 : Math.max(100, firstLevelKeysCount)
+            indexes: isTableRowsRequest ? 1000 : Math.max(10, firstLevelKeysCount)
         };
 
         try {

_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to