Title: [184807] trunk/Tools
- Revision
- 184807
- Author
- a...@apple.com
- Date
- 2015-05-22 17:26:54 -0700 (Fri, 22 May 2015)
Log Message
REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
https://bugs.webkit.org/show_bug.cgi?id=130463
rdar://problem/20461342
Reviewed by Tim Horton.
This was more of a timing related flakiness than an actual OS version specific bug,
we weren't getting window visibility notifications.
I will look into adding this function call to DumpRenderTree separately, layout tests
might actually rely on the broken behavior.
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
(TestWebKitAPI::TEST_F):
* TestWebKitAPI/mac/mainMac.mm:
(main):
Modified Paths
Diff
Modified: trunk/Tools/ChangeLog (184806 => 184807)
--- trunk/Tools/ChangeLog 2015-05-23 00:25:31 UTC (rev 184806)
+++ trunk/Tools/ChangeLog 2015-05-23 00:26:54 UTC (rev 184807)
@@ -1,3 +1,22 @@
+2015-05-22 Alexey Proskuryakov <a...@apple.com>
+
+ REGRESSION (OS X 10.9.2): PageVisibilityStateWithWindowChanges.WebKit2 API test fails
+ https://bugs.webkit.org/show_bug.cgi?id=130463
+ rdar://problem/20461342
+
+ Reviewed by Tim Horton.
+
+ This was more of a timing related flakiness than an actual OS version specific bug,
+ we weren't getting window visibility notifications.
+
+ I will look into adding this function call to DumpRenderTree separately, layout tests
+ might actually rely on the broken behavior.
+
+ * TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
+ (TestWebKitAPI::TEST_F):
+ * TestWebKitAPI/mac/mainMac.mm:
+ (main):
+
2015-05-22 Dana Burkart <dburk...@apple.com>
Add missing file from r184804 (mis-applied diff).
Modified: trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm (184806 => 184807)
--- trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm 2015-05-23 00:25:31 UTC (rev 184806)
+++ trunk/Tools/TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm 2015-05-23 00:26:54 UTC (rev 184807)
@@ -31,10 +31,6 @@
#import <WebKit/WKViewPrivate.h>
#import <wtf/RetainPtr.h>
-// https://bugs.webkit.org/show_bug.cgi?id=130463
-// rdar://problem/20461342
-#if __MAC_OS_X_VERSION_MIN_REQUIRED == 101000
-
static bool isWaitingForPageSignalToContinue = false;
static bool didGetPageSignalToContinue = false;
@@ -180,5 +176,3 @@
}
} // namespace TestWebKitAPI
-
-#endif
Modified: trunk/Tools/TestWebKitAPI/mac/mainMac.mm (184806 => 184807)
--- trunk/Tools/TestWebKitAPI/mac/mainMac.mm 2015-05-23 00:25:31 UTC (rev 184806)
+++ trunk/Tools/TestWebKitAPI/mac/mainMac.mm 2015-05-23 00:26:54 UTC (rev 184807)
@@ -26,12 +26,16 @@
#import "config.h"
#import "TestsController.h"
+extern "C" void _BeginEventReceiptOnThread(void);
+
int main(int argc, char** argv)
{
NSAutoreleasePool *pool = [[NSAutoreleasePool alloc] init];
[[NSUserDefaults standardUserDefaults] removePersistentDomainForName:@"TestWebKitAPI"];
+
[NSApplication sharedApplication];
+ _BeginEventReceiptOnThread(); // Makes window visibility notifications work (and possibly more).
bool passed = TestWebKitAPI::TestsController::singleton().run(argc, argv);
_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes
