[webkit-changes] [184833] trunk/Source/WebKit2

[commit-queue]

Title: [184833] trunk/Source/WebKit2

Revision

184833

Author

commit-qu...@webkit.org

Date

2015-05-23 18:26:34 -0700 (Sat, 23 May 2015)

Log Message

Rename ShareableResource::create(Handle&) to map(Handle&) to match SharedMemory.
https://bugs.webkit.org/show_bug.cgi?id=145288

Patch by Sungmann Cho <sungmann....@navercorp.com> on 2015-05-23
Reviewed by Sam Weinig.

* Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
(WebKit::ShareableResource::map):
(WebKit::ShareableResource::create): Deleted.
* Shared/ShareableResource.h:

Modified Paths

• trunk/Source/WebKit2/ChangeLog
• trunk/Source/WebKit2/Shared/ShareableResource.cpp
• trunk/Source/WebKit2/Shared/ShareableResource.h

Diff

Modified: trunk/Source/WebKit2/ChangeLog (184832 => 184833)

--- trunk/Source/WebKit2/ChangeLog	2015-05-24 01:22:53 UTC (rev 184832)
+++ trunk/Source/WebKit2/ChangeLog	2015-05-24 01:26:34 UTC (rev 184833)
@@ -1,3 +1,16 @@
+2015-05-23  Sungmann Cho  <sungmann....@navercorp.com>
+
+        Rename ShareableResource::create(Handle&) to map(Handle&) to match SharedMemory.
+        https://bugs.webkit.org/show_bug.cgi?id=145288
+
+        Reviewed by Sam Weinig.
+
+        * Shared/ShareableResource.cpp:
+        (WebKit::ShareableResource::Handle::tryWrapInSharedBuffer):
+        (WebKit::ShareableResource::map):
+        (WebKit::ShareableResource::create): Deleted.
+        * Shared/ShareableResource.h:
+
 2015-05-22  Jon Lee  <jon...@apple.com>
 
         Rename MediaPlaybackAllowsInline

Modified: trunk/Source/WebKit2/Shared/ShareableResource.cpp (184832 => 184833)

--- trunk/Source/WebKit2/Shared/ShareableResource.cpp	2015-05-24 01:22:53 UTC (rev 184832)
+++ trunk/Source/WebKit2/Shared/ShareableResource.cpp	2015-05-24 01:26:34 UTC (rev 184833)
@@ -98,7 +98,7 @@
 
 PassRefPtr<SharedBuffer> ShareableResource::Handle::tryWrapInSharedBuffer() const
 {
-    RefPtr<ShareableResource> resource = ShareableResource::create(*this);
+    RefPtr<ShareableResource> resource = ShareableResource::map(*this);
     if (!resource) {
         LOG_ERROR("Failed to recreate ShareableResource from handle.");
         return nullptr;
@@ -112,7 +112,7 @@
     return adoptRef(new ShareableResource(sharedMemory, offset, size));
 }
 
-PassRefPtr<ShareableResource> ShareableResource::create(const Handle& handle)
+PassRefPtr<ShareableResource> ShareableResource::map(const Handle& handle)
 {
     RefPtr<SharedMemory> sharedMemory = SharedMemory::map(handle.m_handle, SharedMemory::Protection::ReadOnly);
     if (!sharedMemory)

Modified: trunk/Source/WebKit2/Shared/ShareableResource.h (184832 => 184833)

--- trunk/Source/WebKit2/Shared/ShareableResource.h	2015-05-24 01:22:53 UTC (rev 184832)
+++ trunk/Source/WebKit2/Shared/ShareableResource.h	2015-05-24 01:26:34 UTC (rev 184833)
@@ -70,8 +70,7 @@
     static PassRefPtr<ShareableResource> create(PassRefPtr<SharedMemory>, unsigned offset, unsigned size);
 
     // Create a shareable resource from a handle.
-    // FIXME: Rename this to map.
-    static PassRefPtr<ShareableResource> create(const Handle&);
+    static PassRefPtr<ShareableResource> map(const Handle&);
 
     // Create a handle.
     bool createHandle(Handle&);

_______________________________________________
webkit-changes mailing list
webkit-changes@lists.webkit.org
https://lists.webkit.org/mailman/listinfo/webkit-changes