Modified: trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js (184857 => 184858)
--- trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-05-26 11:53:15 UTC (rev 184857)
+++ trunk/Tools/BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js 2015-05-26 17:23:49 UTC (rev 184858)
@@ -64,29 +64,26 @@
BuildbotIteration.RETRY = 5;
// If none of these steps ran, then we didn't get any real results, and the iteration was not productive.
+// All test steps are considered productive too.
BuildbotIteration.ProductiveSteps = {
- "compile-webkit": 1,
- "build ASan archive": 1,
"Build" : 1,
- "layout-test": 1,
- "jscore-test": 1,
- "run-api-tests": 1,
- "API tests": 1,
- "webkitpy-test": 1,
- "webkitperl-test": 1,
- "bindings-generation-tests": 1,
- "perf-test": 1,
+ "build ASan archive": 1,
+ "compile-webkit": 1,
"scan build": 1,
};
+// These have a special meaning for test queue views.
BuildbotIteration.TestSteps = {
- "layout-test": "layout test",
+ "API tests": "platform api test",
+ "bindings-generation-tests": "bindings tests",
"jscore-test": "_javascript_ test",
+ "layout-test": "layout test",
+ "perf-test": "performance test",
"run-api-tests": "api test",
- "API tests": "platform api test",
- "webkitpy-test": "webkitpy test",
+ "webkit-32bit-jsc-test": "_javascript_ test",
+ "webkit-jsc-cloop-test": "_javascript_ cloop test",
"webkitperl-test": "webkitperl test",
- "bindings-generation-tests": "bindings tests",
+ "webkitpy-test": "webkitpy test",
};
BuildbotIteration.Event = {
@@ -274,7 +271,7 @@
var step = data.steps[i];
if (!step.isFinished)
break;
- if (step.name in BuildbotIteration.ProductiveSteps) {
+ if (step.name in BuildbotIteration.ProductiveSteps || step.name in BuildbotIteration.TestSteps) {
finishedAnyProductiveStep = true;
break;
}
Modified: trunk/Tools/ChangeLog (184857 => 184858)
--- trunk/Tools/ChangeLog 2015-05-26 11:53:15 UTC (rev 184857)
+++ trunk/Tools/ChangeLog 2015-05-26 17:23:49 UTC (rev 184858)
@@ -1,3 +1,13 @@
+2015-05-26 Alexey Proskuryakov <[email protected]>
+
+ build.webkit.org/dashboard: Don't list test steps in BuildbotIteration twice
+ https://bugs.webkit.org/show_bug.cgi?id=145342
+
+ Reviewed by Darin Adler.
+
+ * BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/BuildbotIteration.js:
+ (BuildbotIteration.prototype._parseData):
+
2015-05-26 Milan Crha <[email protected]>
[GTK] Expand wildcards inside generate-inspector-gresource-manifest.py
