Title: [184869] trunk
Revision
184869
Author
[email protected]
Date
2015-05-26 12:50:18 -0700 (Tue, 26 May 2015)

Log Message

CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
https://bugs.webkit.org/show_bug.cgi?id=145343

Patch by Joseph Pecoraro <[email protected]> on 2015-05-26
Reviewed by Timothy Hatcher.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-font-family-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/css/getComputedStyle/resources/property-names.js:

Modified Paths

Diff

Modified: trunk/LayoutTests/ChangeLog (184868 => 184869)


--- trunk/LayoutTests/ChangeLog	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/ChangeLog	2015-05-26 19:50:18 UTC (rev 184869)
@@ -1,3 +1,15 @@
+2015-05-26  Joseph Pecoraro  <[email protected]>
+
+        CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
+        https://bugs.webkit.org/show_bug.cgi?id=145343
+
+        Reviewed by Timothy Hatcher.
+
+        * fast/css/getComputedStyle/computed-style-expected.txt:
+        * fast/css/getComputedStyle/computed-style-font-family-expected.txt:
+        * fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
+        * fast/css/getComputedStyle/resources/property-names.js:
+
 2015-05-26  Yusuke Suzuki  <[email protected]>
 
         [ES6] Implement Array.prototype.copyWithin

Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt (184868 => 184869)


--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-expected.txt	2015-05-26 19:50:18 UTC (rev 184869)
@@ -44,6 +44,7 @@
 float: none;
 font-size: 16px;
 font-style: normal;
+font-synthesis: style weight;
 font-variant: normal;
 font-weight: normal;
 height: 576px;
@@ -140,6 +141,7 @@
 -webkit-column-break-inside: auto;
 -webkit-column-axis: auto;
 column-count: auto;
+column-fill: balance;
 column-gap: normal;
 column-rule-color: rgb(0, 0, 0);
 column-rule-style: none;

Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt (184868 => 184869)


--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-font-family-expected.txt	2015-05-26 19:50:18 UTC (rev 184869)
@@ -3,6 +3,7 @@
 font-family: monospace, 'Lucida Grande', sans-serif;
 font-size: 16px;
 font-style: normal;
+font-synthesis: style weight;
 font-variant: normal;
 font-weight: normal;
 

Modified: trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt (184868 => 184869)


--- trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt	2015-05-26 19:50:18 UTC (rev 184869)
@@ -43,6 +43,7 @@
 float: none
 font-size: 16px
 font-style: normal
+font-synthesis: style weight
 font-variant: normal
 font-weight: normal
 height: 100px
@@ -139,6 +140,7 @@
 -webkit-column-break-inside: auto
 -webkit-column-axis: auto
 column-count: auto
+column-fill: balance
 column-gap: normal
 column-rule-color: rgb(0, 0, 0)
 column-rule-style: none

Modified: trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js (184868 => 184869)


--- trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/fast/css/getComputedStyle/resources/property-names.js	2015-05-26 19:50:18 UTC (rev 184869)
@@ -38,6 +38,7 @@
     "-webkit-column-break-before": true,
     "-webkit-column-break-inside": true,
     "column-count": true,
+    "column-fill": true,
     "column-gap": true,
     "column-rule-color": true,
     "column-rule-style": true,
@@ -181,6 +182,7 @@
     "flood-opacity": true,
     "font-size": true,
     "font-style": true,
+    "font-synthesis": true,
     "font-variant": true,
     "font-weight": true,
     "glyph-orientation-horizontal": true,

Modified: trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt (184868 => 184869)


--- trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/LayoutTests/svg/css/getComputedStyle-basic-expected.txt	2015-05-26 19:50:18 UTC (rev 184869)
@@ -86,6 +86,8 @@
 rect: style.getPropertyCSSValue(font-size) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(font-style) : normal
 rect: style.getPropertyCSSValue(font-style) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(font-synthesis) : style weight
+rect: style.getPropertyCSSValue(font-synthesis) : [object CSSValueList]
 rect: style.getPropertyValue(font-variant) : normal
 rect: style.getPropertyCSSValue(font-variant) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(font-weight) : normal
@@ -278,6 +280,8 @@
 rect: style.getPropertyCSSValue(-webkit-column-axis) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(column-count) : auto
 rect: style.getPropertyCSSValue(column-count) : [object CSSPrimitiveValue]
+rect: style.getPropertyValue(column-fill) : balance
+rect: style.getPropertyCSSValue(column-fill) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(column-gap) : normal
 rect: style.getPropertyCSSValue(column-gap) : [object CSSPrimitiveValue]
 rect: style.getPropertyValue(column-rule-color) : rgb(0, 0, 0)
@@ -604,6 +608,8 @@
 g: style.getPropertyCSSValue(font-size) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(font-style) : normal
 g: style.getPropertyCSSValue(font-style) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(font-synthesis) : style weight
+g: style.getPropertyCSSValue(font-synthesis) : [object CSSValueList]
 g: style.getPropertyValue(font-variant) : normal
 g: style.getPropertyCSSValue(font-variant) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(font-weight) : normal
@@ -796,6 +802,8 @@
 g: style.getPropertyCSSValue(-webkit-column-axis) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(column-count) : auto
 g: style.getPropertyCSSValue(column-count) : [object CSSPrimitiveValue]
+g: style.getPropertyValue(column-fill) : balance
+g: style.getPropertyCSSValue(column-fill) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(column-gap) : normal
 g: style.getPropertyCSSValue(column-gap) : [object CSSPrimitiveValue]
 g: style.getPropertyValue(column-rule-color) : rgb(0, 0, 0)

Modified: trunk/Source/WebCore/ChangeLog (184868 => 184869)


--- trunk/Source/WebCore/ChangeLog	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/Source/WebCore/ChangeLog	2015-05-26 19:50:18 UTC (rev 184869)
@@ -1,3 +1,12 @@
+2015-05-26  Joseph Pecoraro  <[email protected]>
+
+        CSS properties (font-synthesis, column-fill) are missing in getComputedStyles
+        https://bugs.webkit.org/show_bug.cgi?id=145343
+
+        Reviewed by Timothy Hatcher.
+
+        * css/CSSComputedStyleDeclaration.cpp:
+
 2015-05-26  Dan Bernstein  <[email protected]>
 
         <rdar://problem/21104551> Update build settings

Modified: trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp (184868 => 184869)


--- trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2015-05-26 19:47:56 UTC (rev 184868)
+++ trunk/Source/WebCore/css/CSSComputedStyleDeclaration.cpp	2015-05-26 19:50:18 UTC (rev 184869)
@@ -152,6 +152,7 @@
     CSSPropertyFontFamily,
     CSSPropertyFontSize,
     CSSPropertyFontStyle,
+    CSSPropertyFontSynthesis,
     CSSPropertyFontVariant,
     CSSPropertyFontWeight,
     CSSPropertyHeight,
@@ -286,6 +287,7 @@
     CSSPropertyWebkitColumnBreakInside,
     CSSPropertyWebkitColumnAxis,
     CSSPropertyColumnCount,
+    CSSPropertyColumnFill,
     CSSPropertyColumnGap,
     CSSPropertyColumnProgression,
     CSSPropertyColumnRuleColor,
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to