Title: [184917] trunk/Source/_javascript_Core
- Revision
- 184917
- Author
- [email protected]
- Date
- 2015-05-27 13:42:00 -0700 (Wed, 27 May 2015)
Log Message
REGRESSION: These sorting idioms used by Peacekeeper and Browsermark are ~20X slower
https://bugs.webkit.org/show_bug.cgi?id=145412
Reviewed by Darin Adler.
Use @toString instead of the String constructor because calls to the
String constructor are never optimized. (See
https://bugs.webkit.org/show_bug.cgi?id=144458.)
This is a ~2X speedup.
* builtins/Array.prototype.js:
(sort.stringComparator):
Modified Paths
Diff
Modified: trunk/Source/_javascript_Core/ChangeLog (184916 => 184917)
--- trunk/Source/_javascript_Core/ChangeLog 2015-05-27 20:33:09 UTC (rev 184916)
+++ trunk/Source/_javascript_Core/ChangeLog 2015-05-27 20:42:00 UTC (rev 184917)
@@ -1,3 +1,19 @@
+2015-05-27 Geoffrey Garen <[email protected]>
+
+ REGRESSION: These sorting idioms used by Peacekeeper and Browsermark are ~20X slower
+ https://bugs.webkit.org/show_bug.cgi?id=145412
+
+ Reviewed by Darin Adler.
+
+ Use @toString instead of the String constructor because calls to the
+ String constructor are never optimized. (See
+ https://bugs.webkit.org/show_bug.cgi?id=144458.)
+
+ This is a ~2X speedup.
+
+ * builtins/Array.prototype.js:
+ (sort.stringComparator):
+
2015-05-27 Dan Bernstein <[email protected]>
Remove JSC_OBJC_API_AVAILABLE_MAC_OS_X_1080
Modified: trunk/Source/_javascript_Core/builtins/Array.prototype.js (184916 => 184917)
--- trunk/Source/_javascript_Core/builtins/Array.prototype.js 2015-05-27 20:33:09 UTC (rev 184916)
+++ trunk/Source/_javascript_Core/builtins/Array.prototype.js 2015-05-27 20:42:00 UTC (rev 184917)
@@ -286,8 +286,8 @@
function stringComparator(a, b)
{
- var aString = @String(a);
- var bString = @String(b);
+ var aString = @toString(a);
+ var bString = @toString(b);
var aLength = aString.length;
var bLength = bString.length;
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
