Title: [184993] trunk/Source/WebInspectorUI
- Revision
- 184993
- Author
- [email protected]
- Date
- 2015-05-29 11:05:51 -0700 (Fri, 29 May 2015)
Log Message
Web Inspector: Restoring the last selected DOM node fails on reload (DOMAgent: No node with given path found)
https://bugs.webkit.org/show_bug.cgi?id=144231
Reviewed by Timothy Hatcher.
Removed _restoreSelectedNodeIsAllowed flag from DOMTreeContentView. The frontend receives two documentUpdated
events from the DOM Agent during page reload, and the flag was preventing DOMTreeContentView from restoring
the previous selection in response to the second event.
* UserInterface/Views/DOMTreeContentView.js:
(WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
(WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
Modified Paths
Diff
Modified: trunk/Source/WebInspectorUI/ChangeLog (184992 => 184993)
--- trunk/Source/WebInspectorUI/ChangeLog 2015-05-29 17:51:51 UTC (rev 184992)
+++ trunk/Source/WebInspectorUI/ChangeLog 2015-05-29 18:05:51 UTC (rev 184993)
@@ -1,3 +1,18 @@
+2015-05-29 Matt Baker <[email protected]>
+
+ Web Inspector: Restoring the last selected DOM node fails on reload (DOMAgent: No node with given path found)
+ https://bugs.webkit.org/show_bug.cgi?id=144231
+
+ Reviewed by Timothy Hatcher.
+
+ Removed _restoreSelectedNodeIsAllowed flag from DOMTreeContentView. The frontend receives two documentUpdated
+ events from the DOM Agent during page reload, and the flag was preventing DOMTreeContentView from restoring
+ the previous selection in response to the second event.
+
+ * UserInterface/Views/DOMTreeContentView.js:
+ (WebInspector.DOMTreeContentView.prototype.selectLastSelectedNode):
+ (WebInspector.DOMTreeContentView.prototype._restoreSelectedNodeAfterUpdate):
+
2015-05-28 Nikita Vasilyev <[email protected]>
Web Inspector: Update toolbar styles
Modified: trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js (184992 => 184993)
--- trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-05-29 17:51:51 UTC (rev 184992)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js 2015-05-29 18:05:51 UTC (rev 184993)
@@ -59,7 +59,6 @@
this._lastSelectedNodePathSetting = new WebInspector.Setting("last-selected-node-path", null);
- this._restoreSelectedNodeIsAllowed = true;
this._numberOfSearchResults = null;
};
@@ -146,7 +145,6 @@
selectAndRevealDOMNode: function(domNode, preventFocusChange)
{
- this._restoreSelectedNodeIsAllowed = false;
this._domTreeOutline.selectDOMNode(domNode, !preventFocusChange);
},
@@ -324,7 +322,7 @@
_restoreSelectedNodeAfterUpdate: function(documentURL, defaultNode)
{
- if (!this._restoreSelectedNodeIsAllowed || !WebInspector.domTreeManager.restoreSelectedNodeIsAllowed)
+ if (!WebInspector.domTreeManager.restoreSelectedNodeIsAllowed)
return;
function selectNode(lastSelectedNode)
@@ -347,7 +345,7 @@
function selectLastSelectedNode(nodeId)
{
- if (!this._restoreSelectedNodeIsAllowed || !WebInspector.domTreeManager.restoreSelectedNodeIsAllowed)
+ if (!WebInspector.domTreeManager.restoreSelectedNodeIsAllowed)
return;
selectNode.call(this, WebInspector.domTreeManager.nodeForId(nodeId));
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes
