Title: [185015] trunk/Source/WebInspectorUI
Revision
185015
Author
[email protected]
Date
2015-05-29 16:07:42 -0700 (Fri, 29 May 2015)

Log Message

Web Inspector: Activity Viewer does not update on "clear all console messages"
https://bugs.webkit.org/show_bug.cgi?id=144681

Patch by Tobias Reiss <[email protected]> on 2015-05-29
Reviewed by Joseph Pecoraro.

Do not apply "ignoreDidClearMessages" hack on "Clear log" Button and Context menu.

* UserInterface/Views/LogContentView.js:
(WebInspector.LogContentView.prototype._sessionStarted):
(WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages):
(WebInspector.LogContentView.prototype._clearLog): Deleted.

Modified Paths

Diff

Modified: trunk/Source/WebInspectorUI/ChangeLog (185014 => 185015)


--- trunk/Source/WebInspectorUI/ChangeLog	2015-05-29 23:03:45 UTC (rev 185014)
+++ trunk/Source/WebInspectorUI/ChangeLog	2015-05-29 23:07:42 UTC (rev 185015)
@@ -1,3 +1,17 @@
+2015-05-29  Tobias Reiss  <[email protected]>
+
+        Web Inspector: Activity Viewer does not update on "clear all console messages"
+        https://bugs.webkit.org/show_bug.cgi?id=144681
+
+        Reviewed by Joseph Pecoraro.
+
+        Do not apply "ignoreDidClearMessages" hack on "Clear log" Button and Context menu.
+
+        * UserInterface/Views/LogContentView.js:
+        (WebInspector.LogContentView.prototype._sessionStarted):
+        (WebInspector.LogContentView.prototype._clearLogIgnoringClearMessages):
+        (WebInspector.LogContentView.prototype._clearLog): Deleted.
+
 2015-05-29  Matt Baker  <[email protected]>
 
         Web Inspector: Remove unused expandTreeElementsWhenArrowing property from TreeOutline

Modified: trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js (185014 => 185015)


--- trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2015-05-29 23:03:45 UTC (rev 185014)
+++ trunk/Source/WebInspectorUI/UserInterface/Views/LogContentView.js	2015-05-29 23:07:42 UTC (rev 185015)
@@ -303,7 +303,7 @@
     _sessionStarted: function(event)
     {
         if (this._clearLogOnReloadSetting.value)  {
-            this._clearLog();
+            this._clearLogIgnoringClearMessages();
             this._reappendProvisionalMessages();
             return;
         }
@@ -631,6 +631,14 @@
         this._ignoreDidClearMessages = false;
     },
 
+    // FIXME: <https://webkit.org/b/145466> Web Inspector: Activity Viewer does not update on "Clear Log on reload"
+    _clearLogIgnoringClearMessages: function()
+    {
+        this._ignoreDidClearMessages = true;
+        this._logViewController.clear();
+        this._ignoreDidClearMessages = false;
+    },
+
     _showConsoleTab: function()
     {
         WebInspector.showConsoleTab();
@@ -643,9 +651,7 @@
 
     _clearLog: function()
     {
-        this._ignoreDidClearMessages = true;
         this._logViewController.clear();
-        this._ignoreDidClearMessages = false;
     },
 
     _scopeBarSelectionDidChange: function(event)
_______________________________________________
webkit-changes mailing list
[email protected]
https://lists.webkit.org/mailman/listinfo/webkit-changes

Reply via email to